Benjamin Herrenschmidt wrote: > On Mon, 2005-01-31 at 16:43 -0600, Brian King wrote: > > >>diff -puN include/asm-ppc64/prom.h~ppc64_pcix_mode2_cfg include/asm-ppc64/prom.h >>--- linux-2.6.11-rc2-bk9/include/asm-ppc64/prom.h~ppc64_pcix_mode2_cfg 2005-01-31 14:32:01.000000000 -0600 >>+++ linux-2.6.11-rc2-bk9-bjking1/include/asm-ppc64/prom.h 2005-01-31 14:32:01.000000000 -0600 >>@@ -137,6 +137,7 @@ struct device_node { >> int devfn; /* for pci devices */ >> int eeh_mode; /* See eeh.h for possible EEH_MODEs */ >> int eeh_config_addr; >>+ int pci_ext_config_space; /* for phb's or bridges */ >> struct pci_controller *phb; /* for pci devices */ >> struct iommu_table *iommu_table; /* for phb's or bridges */ > > > Grrr... more crap added to the device-node, I don't like that ... > > This is a PHB only field, can't it be in struct pci_controller instead ? Assuming I am reading the spec correctly, this is only a property of the PHB, so I could move it into the pci_controller struct instead. -- Brian King eServer Storage I/O IBM Linux Technology Center