From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Richard Henderson <rth@twiddle.net>
Cc: linux-arch@vger.kernel.org, Andrew Morton <akpm@osdl.org>
Subject: Re: Lots of possible arch breakage in cpu_idle!!
Date: Mon, 30 May 2005 10:37:47 +1000 [thread overview]
Message-ID: <429A605B.4050503@yahoo.com.au> (raw)
In-Reply-To: <20050529165557.GA19922@twiddle.net>
Richard Henderson wrote:
> On Sun, May 29, 2005 at 03:25:19PM +1000, Nick Piggin wrote:
>
>>+++ linux-2.6/arch/alpha/kernel/process.c
>
> ...
>
>>+ set_thread_flag(TIF_POLLING_NRFLAG);
>
>
> Ok.
>
Good.
>
>>+ cpu_relax();
>>+ preempt_enable_no_resched();
>> schedule();
>>+ preempt_disable();
>
>
> Not ok.
>
>
>>+++ linux-2.6/arch/s390/kernel/smp.c 2005-05-29 14:21:42.000000000 +1000
>>@@ -528,6 +528,8 @@ extern void pfault_fini(void);
>>
>> int __devinit start_secondary(void *cpuvoid)
>> {
>>+ preempt_disable();
>
>
> Not ok.
>
I'll take it you meant:
+++ linux-2.6/arch/alpha/kernel/smp.c 2005-05-29 14:21:42.000000000 +1000
> Do not add the substring "preempt" to the alpha subtree.
>
Sure. Thanks for the feedback.
--
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com
next prev parent reply other threads:[~2005-05-30 0:37 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-29 5:25 Lots of possible arch breakage in cpu_idle!! Nick Piggin
2005-05-29 5:44 ` Andrew Morton
2005-05-29 8:45 ` William Lee Irwin III
2005-05-29 10:03 ` Nick Piggin
2005-05-29 10:13 ` William Lee Irwin III
2005-05-29 11:39 ` William Lee Irwin III
2005-05-29 9:42 ` William Lee Irwin III
2005-05-29 10:08 ` Nick Piggin
2005-05-29 10:14 ` William Lee Irwin III
2005-05-29 16:55 ` Richard Henderson
2005-05-29 20:41 ` David S. Miller
2005-05-29 20:56 ` Richard Henderson
2005-05-30 0:37 ` Nick Piggin [this message]
2005-05-30 11:01 ` Martin Schwidefsky
2005-05-30 11:18 ` Nick Piggin
2005-05-30 11:34 ` Martin Schwidefsky
2005-05-30 11:49 ` Nick Piggin
2005-05-31 8:56 ` David Howells
2005-05-31 9:02 ` Nick Piggin
2005-05-31 9:05 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=429A605B.4050503@yahoo.com.au \
--to=nickpiggin@yahoo.com.au \
--cc=akpm@osdl.org \
--cc=linux-arch@vger.kernel.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox