From: David Howells <dhowells@redhat.com>
To: Chen Gang <gang.chen@asianux.com>
Cc: dhowells@redhat.com, Geert Uytterhoeven <geert@linux-m68k.org>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
jang@linux.vnet.ibm.com, linux390@de.ibm.com,
linux-s390@vger.kernel.org,
Linux-Arch <linux-arch@vger.kernel.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH v2] arch: s390: appldata: using strncpy() and strnlen() instead of sprintf()
Date: Tue, 28 May 2013 11:22:33 +0100 [thread overview]
Message-ID: <4310.1369736553@warthog.procyon.org.uk> (raw)
In-Reply-To: <51A32D81.2010105@asianux.com>
Chen Gang <gang.chen@asianux.com> wrote:
> - len = sprintf(buf, appldata_timer_active ? "1\n" : "0\n");
> + strncpy(buf, appldata_timer_active ? "1\n" : "0\n",
> + ARRAY_SIZE(buf));
> + len = strnlen(buf, ARRAY_SIZE(buf));
Since the strings here are a fixed, preknown size, you should use memcpy (or
just fill in the array directly which would likely take fewer instructions
since the strings are so short and vary by one character) and hard-code the
length or use sizeof() instead of strnlen().
David
next prev parent reply other threads:[~2013-05-28 10:22 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-27 2:59 [PATCH] arch: s390: appldata: using strncpy() instead of sprintf() Chen Gang
2013-05-27 8:34 ` Geert Uytterhoeven
2013-05-27 9:06 ` Chen Gang
2013-05-27 9:43 ` [PATCH] arch: s390: include: asm: typo issue for the redundency comma, found by cross compiling Chen Gang
2013-05-27 9:55 ` [PATCH v2] arch: s390: appldata: using strncpy() and strnlen() instead of sprintf() Chen Gang
2013-05-27 16:23 ` Gerald Schaefer
2013-05-28 4:58 ` Chen Gang
2013-05-28 10:22 ` David Howells [this message]
2013-05-28 11:03 ` Chen Gang
2013-05-28 12:17 ` David Howells
2013-05-28 16:03 ` Gerald Schaefer
2013-05-29 1:40 ` Chen Gang
2013-05-29 1:28 ` Chen Gang
2013-05-29 6:30 ` Dan Carpenter
2013-05-29 7:29 ` Chen Gang
2013-05-29 7:47 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4310.1369736553@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=gang.chen@asianux.com \
--cc=geert@linux-m68k.org \
--cc=heiko.carstens@de.ibm.com \
--cc=jang@linux.vnet.ibm.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux390@de.ibm.com \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox