public inbox for linux-arch@vger.kernel.org
 help / color / mirror / Atom feed
From: David Howells <dhowells-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Harvey Harrison
	<harvey.harrison-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: dhowells-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
	Russell King <rmk-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
	Andrew Morton
	<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
	linux-arch <linux-arch-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Linus Torvalds
	<torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
Subject: Re: [PATCHv3 2/2] kernel: Move arches to use common unaligned access
Date: Mon, 14 Apr 2008 11:32:09 +0100	[thread overview]
Message-ID: <4392.1208169129@redhat.com> (raw)
In-Reply-To: <1207950449.22001.106.camel@brick>

Harvey Harrison <harvey.harrison-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:

> -#ifndef _ASM_UNALIGNED_H
> -#define _ASM_UNALIGNED_H
> +#ifndef _ASM_FRV_UNALIGNED_H_
> +#define _ASM_FRV_UNALIGNED_H_

Please don't.  Why do you need to change these to make your patch work?

> -extern int handle_misalignment(unsigned long esr0, unsigned long ear0, unsigned long epcr0);

Don't lose this please, not unless you're going to erase the
handle_misalignment() function and remove the refs to it.

David

WARNING: multiple messages have this Message-ID (diff)
From: David Howells <dhowells@redhat.com>
To: Harvey Harrison <harvey.harrison@gmail.com>
Cc: dhowells@redhat.com, Russell King <rmk@arm.linux.org.uk>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-arch <linux-arch@vger.kernel.org>,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCHv3 2/2] kernel: Move arches to use common unaligned access
Date: Mon, 14 Apr 2008 11:32:09 +0100	[thread overview]
Message-ID: <4392.1208169129@redhat.com> (raw)
Message-ID: <20080414103209.SiHyg3Mx3qU9Pm1WsACDZV5wyF3mU5aP_Quf8b6NGf0@z> (raw)
In-Reply-To: <1207950449.22001.106.camel@brick>

Harvey Harrison <harvey.harrison@gmail.com> wrote:

> -#ifndef _ASM_UNALIGNED_H
> -#define _ASM_UNALIGNED_H
> +#ifndef _ASM_FRV_UNALIGNED_H_
> +#define _ASM_FRV_UNALIGNED_H_

Please don't.  Why do you need to change these to make your patch work?

> -extern int handle_misalignment(unsigned long esr0, unsigned long ear0, unsigned long epcr0);

Don't lose this please, not unless you're going to erase the
handle_misalignment() function and remove the refs to it.

David

  parent reply	other threads:[~2008-04-14 10:32 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-11 21:47 [PATCHv3 2/2] kernel: Move arches to use common unaligned access Harvey Harrison
2008-04-11 21:47 ` Harvey Harrison
2008-04-14 10:32 ` David Howells [this message]
2008-04-14 10:32   ` David Howells
     [not found]   ` <4392.1208169129-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2008-04-14 11:11     ` Russell King
2008-04-14 11:11       ` Russell King
     [not found]       ` <20080414111119.GA6228-f404yB8NqCZvn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2008-04-14 16:27         ` Harvey Harrison
2008-04-14 16:27           ` Harvey Harrison
2008-04-14 16:34           ` Russell King
2008-04-14 16:34             ` Russell King
     [not found]             ` <20080414163448.GA8473-f404yB8NqCZvn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2008-04-14 16:52               ` Harvey Harrison
2008-04-14 16:52                 ` Harvey Harrison

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4392.1208169129@redhat.com \
    --to=dhowells-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
    --cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
    --cc=harvey.harrison-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=linux-arch-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=rmk-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org \
    --cc=torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox