From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Ellerman Subject: Re: [v6, 1/5] powerpc: add __NR_syscalls along with NR_syscalls Date: Mon, 24 Dec 2018 00:28:03 +1100 (AEDT) Message-ID: <43N38M4cw7z9sNJ@ozlabs.org> References: <1545043236-11649-2-git-send-email-firoz.khan@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1545043236-11649-2-git-send-email-firoz.khan@linaro.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: y2038-bounces@lists.linaro.org Sender: "Y2038" To: linuxppc-dev@lists.ozlabs.org, sathnaga@linux.vnet.ibm.com, Benjamin Herrenschmidt , Paul Mackerras , Arnd Bergmann , Geert Uytterhoeven , Ram Pai , Mathieu Desnoyers , Boqun Feng , Breno Leitao , Greg Kroah-Hartman , Philippe Ombredanne , Thomas Gleixner , Kate Stewart Cc: linux-arch@vger.kernel.org, y2038@lists.linaro.org, linux-kernel@vger.kernel.org, marcin.juszkiewicz@linaro.org, firoz.khan@linaro.org, deepa.kernel@gmail.com List-Id: linux-arch.vger.kernel.org T24gTW9uLCAyMDE4LTEyLTE3IGF0IDEwOjQwOjMyIFVUQywgRmlyb3ogS2hhbiB3cm90ZToKPiBO Ul9zeXNjYWxscyBtYWNybyBob2xkcyB0aGUgbnVtYmVyIG9mIHN5c3RlbSBjYWxsIGV4aXN0Cj4g aW4gcG93ZXJwYyBhcmNoaXRlY3R1cmUuIFdlIGhhdmUgdG8gY2hhbmdlIHRoZSB2YWx1ZSBvZgo+ IE5SX3N5c2NhbGxzLCBpZiB3ZSBhZGQgb3IgZGVsZXRlIGEgc3lzdGVtIGNhbGwuCj4gCj4gT25l IG9mIHRoZSBwYXRjaCBpbiB0aGlzIHBhdGNoIHNlcmllcyBoYXMgYSBzY3JpcHQgd2hpY2gKPiB3 aWxsIGdlbmVyYXRlIGEgdWFwaSBoZWFkZXIgYmFzZWQgb24gc3lzY2FsbC50YmwgZmlsZS4KPiBU aGUgc3lzY2FsbC50YmwgZmlsZSBjb250YWlucyB0aGUgbnVtYmVyIG9mIHN5c3RlbSBjYWxsCj4g aW5mb3JtYXRpb24uIFNvIHdlIGhhdmUgdHdvIG9wdGlvbiB0byB1cGRhdGUgTlJfc3lzY2FsbHMK PiB2YWx1ZS4KPiAKPiAxLiBVcGRhdGUgTlJfc3lzY2FsbHMgaW4gYXNtL3VuaXN0ZC5oIG1hbnVh bGx5IGJ5IGNvdW50LQo+ICAgIGluZyB0aGUgbm8ub2Ygc3lzdGVtIGNhbGxzLiBObyBuZWVkIHRv IHVwZGF0ZSBOUl9zeXMtCj4gICAgY2FsbHMgdW50aWwgd2UgZWl0aGVyIGFkZCBhIG5ldyBzeXN0 ZW0gY2FsbCBvciBkZWxldGUKPiAgICBleGlzdGluZyBzeXN0ZW0gY2FsbC4KPiAKPiAyLiBXZSBj YW4ga2VlcCB0aGlzIGZlYXR1cmUgaW4gYWJvdmUgbWVudGlvbmVkIHNjcmlwdCwKPiAgICB0aGF0 IHdpbGwgY291bnQgdGhlIG51bWJlciBvZiBzeXNjYWxscyBhbmQga2VlcCBpdCBpbgo+ICAgIGEg Z2VuZXJhdGVkIGZpbGUuIEluIHRoaXMgY2FzZSB3ZSBkb24ndCBuZWVkIHRvIGV4cGxpLQo+ICAg IGNpdGx5IHVwZGF0ZSBOUl9zeXNjYWxscyBpbiBhc20vdW5pc3RkLmggZmlsZS4KPiAKPiBUaGUg Mm5kIG9wdGlvbiB3aWxsIGJlIHRoZSByZWNvbW1lbmRlZCBvbmUuIEZvciB0aGF0LCBJCj4gYWRk ZWQgdGhlIF9fTlJfc3lzY2FsbHMgbWFjcm8gaW4gdWFwaS9hc20vdW5pc3RkLmggYWxvbmcKPiB3 aXRoIE5SX3N5c2NhbGxzIGFzbS91bmlzdGQuaC4gVGhlIG1hY3JvIF9fTlJfc3lzY2FsbHMKPiBh bHNvIGFkZGVkIGZvciBtYWtpbmcgdGhlIG5hbWUgY29udmVudGlvbiBzYW1lIGFjcm9zcyBhbGwK PiBhcmNoaXRlY3R1cmUuIFdoaWxlIF9fTlJfc3lzY2FsbHMgaXNuJ3Qgc3RyaWN0bHkgcGFydCBv Zgo+IHRoZSB1YXBpLCBoYXZpbmcgaXQgYXMgcGFydCBvZiB0aGUgZ2VuZXJhdGVkIGhlYWRlciB0 bwo+IHNpbXBsaWZpZXMgdGhlIGltcGxlbWVudGF0aW9uLiBXZSBhbHNvIG5lZWQgdG8gZW5jbG9z ZQo+IHRoaXMgbWFjcm8gd2l0aCAjaWZkZWYgX19LRVJORUxfXyB0byBhdm9pZCBzaWRlIGVmZmVj dHMuCj4gCj4gU2lnbmVkLW9mZi1ieTogRmlyb3ogS2hhbiA8Zmlyb3oua2hhbkBsaW5hcm8ub3Jn PgoKU2VyaWVzIGFwcGxpZWQgdG8gcG93ZXJwYyBuZXh0LCB0aGFua3MuCgpodHRwczovL2dpdC5r ZXJuZWwub3JnL3Bvd2VycGMvYy84YTE5ZWVlYWI2NmRmZGQ3YzY3YmM4ZTMwNDhhYzAKCmNoZWVy cwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpZMjAzOCBt YWlsaW5nIGxpc3QKWTIwMzhAbGlzdHMubGluYXJvLm9yZwpodHRwczovL2xpc3RzLmxpbmFyby5v cmcvbWFpbG1hbi9saXN0aW5mby95MjAzOAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ozlabs.org ([203.11.71.1]:45771 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728706AbeLWN2G (ORCPT ); Sun, 23 Dec 2018 08:28:06 -0500 In-Reply-To: <1545043236-11649-2-git-send-email-firoz.khan@linaro.org> From: Michael Ellerman Subject: Re: [v6,1/5] powerpc: add __NR_syscalls along with NR_syscalls Message-ID: <43N38M4cw7z9sNJ@ozlabs.org> Date: Mon, 24 Dec 2018 00:28:03 +1100 (AEDT) Sender: linux-arch-owner@vger.kernel.org List-ID: To: Firoz Khan , linuxppc-dev@lists.ozlabs.org, sathnaga@linux.vnet.ibm.com, Benjamin Herrenschmidt , Paul Mackerras , Arnd Bergmann , Geert Uytterhoeven , Ram Pai , Mathieu Desnoyers , Boqun Feng , Breno Leitao , Greg Kroah-Hartman , Philippe Ombredanne , Thomas Gleixner , Kate Stewart Cc: linux-arch@vger.kernel.org, y2038@lists.linaro.org, linux-kernel@vger.kernel.org, marcin.juszkiewicz@linaro.org, deepa.kernel@gmail.com Message-ID: <20181223132803.EwBnad94x4d9ki9utecGljCV42bzrrVO-B0lOZF7NX4@z> On Mon, 2018-12-17 at 10:40:32 UTC, Firoz Khan wrote: > NR_syscalls macro holds the number of system call exist > in powerpc architecture. We have to change the value of > NR_syscalls, if we add or delete a system call. > > One of the patch in this patch series has a script which > will generate a uapi header based on syscall.tbl file. > The syscall.tbl file contains the number of system call > information. So we have two option to update NR_syscalls > value. > > 1. Update NR_syscalls in asm/unistd.h manually by count- > ing the no.of system calls. No need to update NR_sys- > calls until we either add a new system call or delete > existing system call. > > 2. We can keep this feature in above mentioned script, > that will count the number of syscalls and keep it in > a generated file. In this case we don't need to expli- > citly update NR_syscalls in asm/unistd.h file. > > The 2nd option will be the recommended one. For that, I > added the __NR_syscalls macro in uapi/asm/unistd.h along > with NR_syscalls asm/unistd.h. The macro __NR_syscalls > also added for making the name convention same across all > architecture. While __NR_syscalls isn't strictly part of > the uapi, having it as part of the generated header to > simplifies the implementation. We also need to enclose > this macro with #ifdef __KERNEL__ to avoid side effects. > > Signed-off-by: Firoz Khan Series applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/8a19eeeab66dfdd7c67bc8e3048ac0 cheers