From: "Arnd Bergmann" <arnd@arndb.de>
To: "Marius.Cristea" <Marius.Cristea@microchip.com>,
"David Laight" <David.Laight@aculab.com>
Cc: Linux-Arch <linux-arch@vger.kernel.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] asm-generic: introduce be56 unaligned accessors
Date: Mon, 07 Oct 2024 17:08:52 +0000 [thread overview]
Message-ID: <43cee6a3-ce29-402d-978e-a8251d08c522@app.fastmail.com> (raw)
In-Reply-To: <2f53046dd5b791845c2ffa783d7637ca94ca330c.camel@microchip.com>
On Mon, Oct 7, 2024, at 14:57, Marius.Cristea@microchip.com wrote:
> On Mon, 2024-10-07 at 14:44 +0000, Arnd Bergmann wrote:
>
> Most probably this request is quite specific to my driver and I'm not
> sure how often it will be used by somebody else.
>
> I'm using block read in order to get multiple registers at a time
> (around 76 bytes) and to increase the efficiency of the transfer over
> I2C. Being a block read there are different registers length involved
> from 16 up to 56 bits long and I need to unpack.
Ok, makes sense. In this case I would keep the exact implementation
you have but move it into your driver where I guess it started out.
If we ever get multiple drivers that need the same thing, we can
still consolidate the implementation.
Arnd
next prev parent reply other threads:[~2024-10-07 17:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-27 8:35 [PATCH v1] asm-generic: introduce be56 unaligned accessors marius.cristea
2024-09-29 21:16 ` David Laight
2024-10-07 14:40 ` Marius.Cristea
2024-10-07 14:44 ` Arnd Bergmann
2024-10-07 14:57 ` Marius.Cristea
2024-10-07 17:08 ` Arnd Bergmann [this message]
2024-10-08 9:03 ` David Laight
2024-10-07 15:05 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43cee6a3-ce29-402d-978e-a8251d08c522@app.fastmail.com \
--to=arnd@arndb.de \
--cc=David.Laight@aculab.com \
--cc=Marius.Cristea@microchip.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).