From: "Arnd Bergmann" <arnd@arndb.de>
To: "Song Chen" <chensong_2000@189.cn>,
"Steven Rostedt" <rostedt@goodmis.org>,
"Masami Hiramatsu" <mhiramat@kernel.org>,
"Niklas Schnelle" <schnelle@linux.ibm.com>
Cc: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
Linux-Arch <linux-arch@vger.kernel.org>
Subject: Re: [PATCH v3 3/4] include/asm-generic/io.h: remove performing pointer arithmetic on a null pointer
Date: Tue, 06 Dec 2022 15:22:58 +0100 [thread overview]
Message-ID: <43fda82a-f3df-42c8-9eb2-23cf2dce8628@app.fastmail.com> (raw)
In-Reply-To: <0903321f-e0cf-fd7b-bbdd-fc4fdc0f05a0@189.cn>
On Tue, Dec 6, 2022, at 07:01, Song Chen wrote:
> 在 2022/12/5 18:04, Arnd Bergmann 写道:
>> On Mon, Dec 5, 2022, at 09:30, Song Chen wrote:
>>
>> We have discussed this bit multiple times, and Niklas Schnelle
>> last posted his series to fix this as an RFC in [1].
>>
>
> Trace triggers the warning accidentally by including io.h indirectly
> because of the absence of PCI_IOBASE in hexagon. So what trace can do in
> this case is either to suppress warning or just ignore it, the warning
> will go away as long as hexagon has put PCI_IOBASE in place or
> implemented its own inb() etc, i think they will do it sooner or later.
hexagon/riscv/s390 should not implement inb(), there is no reason
for that because no hardware uses it. Half of the other architectures
that currently implement inb() should not do so either.
> Introducing HAS_IOPORT to trace seems no necessary and too much impact.
I don't think that trace has anything to do with it, the asm-generic
header should just not provde the inb() interface on architectures
that don't use it.
Arnd
prev parent reply other threads:[~2022-12-06 14:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-05 8:30 [PATCH v3 3/4] include/asm-generic/io.h: remove performing pointer arithmetic on a null pointer Song Chen
2022-12-05 10:04 ` Arnd Bergmann
2022-12-06 6:01 ` Song Chen
2022-12-06 14:22 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43fda82a-f3df-42c8-9eb2-23cf2dce8628@app.fastmail.com \
--to=arnd@arndb.de \
--cc=chensong_2000@189.cn \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
--cc=schnelle@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox