Re: [PATCH v2 24/29] nios2: Module support

LF.Tan
2014-07-16T01:36:14Z

On Tue, Jul 15, 2014 at 8:21 PM, Arnd Bergmann <arnd@arndb.de> wrote:

>>
>> AFAIR this is due to relocation issues, as the FIXME comment in the
>> "original" code [1] states. I don't know whether this still applies,
>> though (or what would be the proper fix for this to overcome the
>> relocation issues).
>>
>> [1] https://github.com/tklauser/linux-nios2/blob/nios2/arch/nios2/kernel/module.c#L45
>>
>
> Ah, I see. Please at least copy over that comment then.
Will copy over the comment.

>
> A long-term solution would be to copy what ARM does, since that
> has the same problem. The modules are allocated with
> __vmalloc_node_range, passing a virtual address range that
> is just before the kernel virtual address, taken out of the
> top 16MB of the user space addresses.
Noted, will investigate this for long-term solution.

Thanks.

Regards
Ley Foon