Re: [PATCH v2 05/29] nios2: Memory management

Ley Foon Tan
2014-07-30T10:52:50Z

On Wed, Jul 30, 2014 at 4:57 PM, Tobias Klauser <tklauser@distanz.ch> wrote:

>> >> Any chance you can use mmu.h from asm-generic instead?
>> >> It uses a struct with a single "unsigned long end_brk" member (unless
>> >> CONFIG_BINFMT_ELF_FDPIC is defined).
>> > From asm-generic/mmu.h, it is for nommu implementations.
>> > So, I will keep this as it is now.
>>
>> Right, you have a MMU.
>> I got confused by the "Taken from m68knommu" comment, and you still
>> only need a single "unsigned long".
>
> That comment stems from the initial Nios II NOMMU port done by
> Microtronix. Since Nios II NOMMU support was dropped for mainline
> submission anyhow, it might be better to drop that comment to avoid any
> future confusion :)
Okay, I will remove these nommu comments.

Thanks.

Regards
Ley Foon