Re: [PATCH v2 02/29] nios2: Kernel booting and initialization

Ley Foon Tan
2014-07-30T10:58:16Z

On Wed, Jul 30, 2014 at 5:12 PM, Tobias Klauser <tklauser@distanz.ch> wrote:
>> +/*
>> + * Stack layout in 'ret_from_exception':
>> + *
>> + * This allows access to the syscall arguments in registers r4-r8
>> + *
>> + * 0(sp) - r8
>> + * 4(sp) - r9
>> + * 8(sp) - r10
>> + * C(sp) - r11
>> + * 10(sp) - r12
>> + * 14(sp) - r13
>> + * 18(sp) - r14
>> + * 1C(sp) - r15
>> + * 20(sp) - r1
>> + * 24(sp) - r2
>> + * 28(sp) - r3
>> + * 2C(sp) - r4
>> + * 30(sp) - r5
>> + * 34(sp) - r6
>> + * 38(sp) - r7
>> + * 3C(sp) - orig_r2
>> + * 40(sp) - ra
>> + * 44(sp) - fp
>> + * 48(sp) - sp
>> + * 4C(sp) - gp
>> + * 50(sp) - estatus
>> + * 54(sp) - status_extension (NOMMU only)
>> + * 58(sp) - ea
>> + */
>
> status_extension no longer exists and orig_r7 is missing in the list
> above. Since this corresponds to the order of struct pt_regs anyhow,
> this comment seems rather pointless to me, so you might as well want to
> remove it altogether.
Okay, I will remove these comments.
Thanks for review.

Regards
Ley Foon