Re: [PATCH v2 05/29] nios2: Memory management

Geert Uytterhoeven
2014-07-30T08:18:53Z

On Wed, Jul 30, 2014 at 8:42 AM, Ley Foon Tan <lftan@altera.com> wrote:
> On Mon, Jul 28, 2014 at 10:59 PM, Geert Uytterhoeven
> <geert@linux-m68k.org> wrote:
>> On Tue, Jul 15, 2014 at 10:45 AM, Ley Foon Tan <lftan@altera.com> wrote:
>>> --- /dev/null
>>> +++ b/arch/nios2/include/asm/mmu.h
>>> @@ -0,0 +1,18 @@
>>> +/*
>>> + * Copyright (C) 2010 Tobias Klauser <tklauser@distanz.ch>
>>> + * Copyright (C) 2004 Microtronix Datacom Ltd.
>>> + *
>>> + * Taken from m68knommu.
>>> + *
>>> + * This file is subject to the terms and conditions of the GNU General Public
>>> + * License. See the file "COPYING" in the main directory of this archive
>>> + * for more details.
>>> + */
>>> +
>>> +#ifndef _ASM_NIOS2_MMU_H
>>> +#define _ASM_NIOS2_MMU_H
>>> +
>>> +/* Default "unsigned long" context */
>>> +typedef unsigned long mm_context_t;
>>> +
>>> +#endif /* _ASM_NIOS2_MMU_H */
>>
>> Any chance you can use mmu.h from asm-generic instead?
>> It uses a struct with a single "unsigned long end_brk" member (unless
>> CONFIG_BINFMT_ELF_FDPIC is defined).
> From asm-generic/mmu.h, it is for nommu implementations.
> So, I will keep this as it is now.

Right, you have a MMU.
I got confused by the "Taken from m68knommu" comment, and you still
only need a single "unsigned long".

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds