From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH v3 09/16] rtc: m68k: provide rtc_class_ops directly Date: Thu, 28 Apr 2016 01:04:23 +0200 Message-ID: <4642144.cyaFZ6JYuF@wuerfel> References: <1461796470-1291527-1-git-send-email-arnd@arndb.de> <1461796470-1291527-10-git-send-email-arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <1461796470-1291527-10-git-send-email-arnd@arndb.de> Sender: linux-m68k-owner@vger.kernel.org To: linuxppc-dev@lists.ozlabs.org Cc: Alexandre Belloni , linux-arch@vger.kernel.org, a.zummo@towertech.it, dalias@libc.org, linux-parisc@vger.kernel.org, linux-sh@vger.kernel.org, deller@gmx.de, linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, dhowells@redhat.com, linux-m68k@lists.linux-m68k.org, geert@linux-m68k.org, rtc-linux@googlegroups.com List-Id: linux-arch.vger.kernel.org On Thursday 28 April 2016 00:34:23 Arnd Bergmann wrote: > return -ENODEV; > > - pdev = platform_device_register_simple("rtc-generic", -1, NULL, 0); > + /* or just call devm_rtc_device_register instead? */ Oops, I was planning to remove the comment here. I probably have to do a v4 anyway, fixed it up locally now. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.kundenserver.de ([212.227.17.24]:57458 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751731AbcD0XE7 (ORCPT ); Wed, 27 Apr 2016 19:04:59 -0400 From: Arnd Bergmann Subject: Re: [PATCH v3 09/16] rtc: m68k: provide rtc_class_ops directly Date: Thu, 28 Apr 2016 01:04:23 +0200 Message-ID: <4642144.cyaFZ6JYuF@wuerfel> In-Reply-To: <1461796470-1291527-10-git-send-email-arnd@arndb.de> References: <1461796470-1291527-1-git-send-email-arnd@arndb.de> <1461796470-1291527-10-git-send-email-arnd@arndb.de> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-arch-owner@vger.kernel.org List-ID: To: linuxppc-dev@lists.ozlabs.org Cc: Alexandre Belloni , linux-arch@vger.kernel.org, a.zummo@towertech.it, dalias@libc.org, linux-parisc@vger.kernel.org, linux-sh@vger.kernel.org, deller@gmx.de, linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, dhowells@redhat.com, linux-m68k@lists.linux-m68k.org, geert@linux-m68k.org, rtc-linux@googlegroups.com Message-ID: <20160427230423.92z00Y2QAyTQLJ09wSmU20JYALOsIILma_T3C-S4rnw@z> On Thursday 28 April 2016 00:34:23 Arnd Bergmann wrote: > return -ENODEV; > > - pdev = platform_device_register_simple("rtc-generic", -1, NULL, 0); > + /* or just call devm_rtc_device_register instead? */ Oops, I was planning to remove the comment here. I probably have to do a v4 anyway, fixed it up locally now. Arnd