Re: [PATCH 0/7][RFC] Move Marvell MBUS window handling into drivers

[Tzachi Perelstein <tzachi-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>]

Lennert Buytenhek wrote:
> 
> This patch set is an initial attempt at moving programming of the
> MBUS register windows for the set of MBUS peripherals that we currently
> have in-tree drivers for from platform code into drivers.
> 
> With these patches, info about DRAM target/attribute IDs is prepared
> by the platform code as usual, but then passed into platform drivers
> via platform device data, instead of programming that data into the
> peripherals directly.
> 
> This avoids duplicating the window programming code across each
> platform that wants to use these peripherals, and avoids exposing
> internal peripheral register set details outside of their drivers.
> 
> Comments appreciated.
> 

At the beginning I had some hard time to agree with this concept 
of leaving the mbus windows to be handled at drivers level instead 
of the arch level, mainly because the mbus bits looks somehow 
different on every orion/discovery chips. My feeling was that this 
approach will either fail on some chips or will be very cumbersome.

Well, I was wrong. Reviewing the patches against orion/discovery 
specs shows that this patchset indeed handles all these bits 
differences correctly, and in a very simple and elegant manner. 
So I like it a lot ;) 

For the whole set --
Reviewed-by: Tzachi Perelstein <tzachi-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>

--
To unsubscribe from this list: send the line "unsubscribe linux-arch" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html