From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 1/11] Add generic helpers for arch IPI function calls Date: Tue, 22 Apr 2008 17:38:25 +0300 Message-ID: <480DF861.6000705@qumranet.com> References: <1208851058-8500-1-git-send-email-jens.axboe@oracle.com> <1208851058-8500-2-git-send-email-jens.axboe@oracle.com> <480DACDD.7040108@qumranet.com> <20080422092230.GW12774@kernel.dk> <20080422111403.GX12774@kernel.dk> <1208869254.7115.258.camel@twins> <20080422142543.GG12774@kernel.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20080422142543.GG12774-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org> Sender: linux-arch-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: To: Jens Axboe Cc: Peter Zijlstra , linux-arch-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, npiggin-l3A5Bk7waGM@public.gmane.org, torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org Jens Axboe wrote: >> Introducing this fallback will make any usage from irq disabled context >> deadlock prone. >> >> I rather like the current interface. >> > > Hmm good point, I'll back that bit out again. > But then you need to fix all callers to handle errors. Perhaps we need a new flag for failable async IPIs (or better, API). I'm pretty sure no one uses s_c_f_s() from irq disabled context on x86, since it will WARN_ON(irqs_disabled()). -- error compiling committee.c: too many arguments to function From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bzq-179-150-194.static.bezeqint.net ([212.179.150.194]:32222 "EHLO il.qumranet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755469AbYDVOi2 (ORCPT ); Tue, 22 Apr 2008 10:38:28 -0400 Message-ID: <480DF861.6000705@qumranet.com> Date: Tue, 22 Apr 2008 17:38:25 +0300 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [PATCH 1/11] Add generic helpers for arch IPI function calls References: <1208851058-8500-1-git-send-email-jens.axboe@oracle.com> <1208851058-8500-2-git-send-email-jens.axboe@oracle.com> <480DACDD.7040108@qumranet.com> <20080422092230.GW12774@kernel.dk> <20080422111403.GX12774@kernel.dk> <1208869254.7115.258.camel@twins> <20080422142543.GG12774@kernel.dk> In-Reply-To: <20080422142543.GG12774@kernel.dk> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: Jens Axboe Cc: Peter Zijlstra , linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, npiggin@suse.de, torvalds@linux-foundation.org Message-ID: <20080422143825.Yt1LIzl6fgAchhm6Mj88Z7nZPAQXF3-fI_vX64H4GSU@z> Jens Axboe wrote: >> Introducing this fallback will make any usage from irq disabled context >> deadlock prone. >> >> I rather like the current interface. >> > > Hmm good point, I'll back that bit out again. > But then you need to fix all callers to handle errors. Perhaps we need a new flag for failable async IPIs (or better, API). I'm pretty sure no one uses s_c_f_s() from irq disabled context on x86, since it will WARN_ON(irqs_disabled()). -- error compiling committee.c: too many arguments to function