From mboxrd@z Thu Jan 1 00:00:00 1970 From: "H. Peter Anvin" Subject: Re: [PATCH 09/24] ia64: types: use for the ia64 architecture Date: Thu, 24 Apr 2008 20:42:12 -0700 Message-ID: <48115314.4090705@zytor.com> References: <1209078352-7593-1-git-send-email-hpa@zytor.com> <1209078352-7593-2-git-send-email-hpa@zytor.com> <1209078352-7593-3-git-send-email-hpa@zytor.com> <1209078352-7593-4-git-send-email-hpa@zytor.com> <1209078352-7593-5-git-send-email-hpa@zytor.com> <1209078352-7593-6-git-send-email-hpa@zytor.com> <1209078352-7593-7-git-send-email-hpa@zytor.com> <1209078352-7593-8-git-send-email-hpa@zytor.com> <1209078352-7593-9-git-send-email-hpa@zytor.com> <1209078352-7593-10-git-send-email-hpa@zytor.com> <1209078352-7593-11-git-send-email-hpa@zytor.com> <1209078352-7593-12-git-send-email-hpa@zytor.com> <1209078352-7593-13-git-send-email-hpa@zytor.com> <1209078352-7593-14-git-send-email-hpa@zytor.com> <1209078352-7593-15-git-send-email-hpa@zytor.com> <1209078352-7593-16-git-send-email-hpa@zytor.co m> <1209078352-7593-17-git-send-email-hpa@zytor.com> <1209078352-7593-18-git-send-email-hpa@zytor.com> <1FE6DD409037234FAB833C420AA843EC012F9FDA@orsmsx424.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1FE6DD409037234FAB833C420AA843EC012F9FDA-7XlYjKTK0pM64kNsxIetb7fspsVTdybXVpNB7YpNyf8@public.gmane.org> Sender: linux-arch-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: To: "Luck, Tony" Cc: Linus Torvalds , Andrew Morton , Linux Kernel Mailing List , Linux Arch Mailing List Luck, Tony wrote: > I get an error while building the ia64 sim_defconfig (which > uses CONFIG_HZ=32) > > kernel/time.c: In function `msecs_to_jiffies': > kernel/time.c:472: error: `MSEC_TO_HZ_MUL32UL' undeclared (first use in this function) > kernel/time.c:472: error: (Each undeclared identifier is reported only once > kernel/time.c:472: error: for each function it appears in.) > > > The generated timeconst.h has: > #define MSEC_TO_HZ_MUL32 0x83126e98 > > So some weird cpp thing happened and the UL got concatenated > before the MSEC_TO_HZ_MUL32 was swapped out for its defined > value. > > All the rest of the ia64 configs build ok. > OK... I'm clearly having a bad day... not only is the last patch in the series (the kernel/time.c stuff) just plain broken, but I ran the wrong test battery on it. I will fix it up and post a replacement patch. -hpa From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from terminus.zytor.com ([198.137.202.10]:40079 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753960AbYDYDmS (ORCPT ); Thu, 24 Apr 2008 23:42:18 -0400 Message-ID: <48115314.4090705@zytor.com> Date: Thu, 24 Apr 2008 20:42:12 -0700 From: "H. Peter Anvin" MIME-Version: 1.0 Subject: Re: [PATCH 09/24] ia64: types: use for the ia64 architecture References: <1209078352-7593-1-git-send-email-hpa@zytor.com> <1209078352-7593-2-git-send-email-hpa@zytor.com> <1209078352-7593-3-git-send-email-hpa@zytor.com> <1209078352-7593-4-git-send-email-hpa@zytor.com> <1209078352-7593-5-git-send-email-hpa@zytor.com> <1209078352-7593-6-git-send-email-hpa@zytor.com> <1209078352-7593-7-git-send-email-hpa@zytor.com> <1209078352-7593-8-git-send-email-hpa@zytor.com> <1209078352-7593-9-git-send-email-hpa@zytor.com> <1209078352-7593-10-git-send-email-hpa@zytor.com> <1209078352-7593-11-git-send-email-hpa@zytor.com> <1209078352-7593-12-git-send-email-hpa@zytor.com> <1209078352-7593-13-git-send-email-hpa@zytor.com> <1209078352-7593-14-git-send-email-hpa@zytor.com> <1209078352-7593-15-git-send-email-hpa@zytor.com> <1209078352-7593-16-git-send-email-hpa@zytor.com> <1209078352-7593-17-git-send-email-hpa@zytor.com> <1209078352-7593-18-git-send-email-hpa@zytor.com> <1FE6DD409037234FAB833C420AA843EC012F9FDA@orsmsx424.amr.corp.intel.com> In-Reply-To: <1FE6DD409037234FAB833C420AA843EC012F9FDA@orsmsx424.amr.corp.intel.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: "Luck, Tony" Cc: Linus Torvalds , Andrew Morton , Linux Kernel Mailing List , Linux Arch Mailing List Message-ID: <20080425034212.A9TkpPyMt0E7r6yvd6gmVEgEgoT0octB6OyWgVC2oEU@z> Luck, Tony wrote: > I get an error while building the ia64 sim_defconfig (which > uses CONFIG_HZ=32) > > kernel/time.c: In function `msecs_to_jiffies': > kernel/time.c:472: error: `MSEC_TO_HZ_MUL32UL' undeclared (first use in this function) > kernel/time.c:472: error: (Each undeclared identifier is reported only once > kernel/time.c:472: error: for each function it appears in.) > > > The generated timeconst.h has: > #define MSEC_TO_HZ_MUL32 0x83126e98 > > So some weird cpp thing happened and the UL got concatenated > before the MSEC_TO_HZ_MUL32 was swapped out for its defined > value. > > All the rest of the ia64 configs build ok. > OK... I'm clearly having a bad day... not only is the last patch in the series (the kernel/time.c stuff) just plain broken, but I ran the wrong test battery on it. I will fix it up and post a replacement patch. -hpa