From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeremy Fitzhardinge Subject: Re: [PATCH 2/11] x86: convert to generic helpers for IPI function calls Date: Sat, 26 Apr 2008 01:59:55 -0700 Message-ID: <4812EF0B.4060109@goop.org> References: <1208851058-8500-1-git-send-email-jens.axboe@oracle.com> <1208851058-8500-3-git-send-email-jens.axboe@oracle.com> <20080422084738.GB2388@elte.hu> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20080422084738.GB2388-X9Un+BFzKDI@public.gmane.org> Sender: linux-arch-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: To: Ingo Molnar Cc: Jens Axboe , linux-arch-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, npiggin-l3A5Bk7waGM@public.gmane.org, torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org, Ingo Molnar , Peter Zijlstra Ingo Molnar wrote: > * Jens Axboe wrote: > > >> This converts x86 and x86-64 to use the new helpers for >> smp_call_function() and friends, and adds support for >> smp_call_function_single(). >> > > nice stuff. The x86 and generic bits: > > Acked-by: Ingo Molnar > > this has been brewing for months, what is the testing/confidence status > of it? Could we still merge it into v2.6.26? (i think we should) > I commented on an earlier version of this patch, but it looks like it will break Xen. If you enable CONFIG_XEN, it will try to define both native and Xen versions of arch_send_call_function[_single]_ipi(). It needs to vector them via smp_ops. J From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gw.goop.org ([64.81.55.164]:35915 "EHLO mail.goop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753287AbYDZJAB (ORCPT ); Sat, 26 Apr 2008 05:00:01 -0400 Message-ID: <4812EF0B.4060109@goop.org> Date: Sat, 26 Apr 2008 01:59:55 -0700 From: Jeremy Fitzhardinge MIME-Version: 1.0 Subject: Re: [PATCH 2/11] x86: convert to generic helpers for IPI function calls References: <1208851058-8500-1-git-send-email-jens.axboe@oracle.com> <1208851058-8500-3-git-send-email-jens.axboe@oracle.com> <20080422084738.GB2388@elte.hu> In-Reply-To: <20080422084738.GB2388@elte.hu> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: Ingo Molnar Cc: Jens Axboe , linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, npiggin@suse.de, torvalds@linux-foundation.org, Ingo Molnar , Peter Zijlstra Message-ID: <20080426085955.171y9GFZRuOer3oHpEWjzTlvDNvM9ioVt2Ujrdq6hHg@z> Ingo Molnar wrote: > * Jens Axboe wrote: > > >> This converts x86 and x86-64 to use the new helpers for >> smp_call_function() and friends, and adds support for >> smp_call_function_single(). >> > > nice stuff. The x86 and generic bits: > > Acked-by: Ingo Molnar > > this has been brewing for months, what is the testing/confidence status > of it? Could we still merge it into v2.6.26? (i think we should) > I commented on an earlier version of this patch, but it looks like it will break Xen. If you enable CONFIG_XEN, it will try to define both native and Xen versions of arch_send_call_function[_single]_ipi(). It needs to vector them via smp_ops. J