From: Jiri Slaby <jirislaby@gmail.com>
To: monstr@seznam.cz
Cc: paulus@samba.org, arnd@arndb.de, linux-kernel@vger.kernel.org,
linux-arch@vger.kernel.org, Michal Simek <monstr@monstr.eu>
Subject: Re: [PATCH 1/2] OF: clean coding style - prom_parse.c
Date: Sat, 03 May 2008 19:25:15 +0200 [thread overview]
Message-ID: <481C9FFB.3090207@gmail.com> (raw)
In-Reply-To: <c382f7ff87d1502c20423742ad738e50a118cf62.1209827449.git.monstr@monstr.eu>
On 05/03/2008 05:13 PM, monstr@seznam.cz wrote:
> From: Michal Simek <monstr@monstr.eu>
>
>
> Signed-off-by: Michal Simek <monstr@monstr.eu>
> ---
> arch/powerpc/kernel/prom_parse.c | 98 ++++++++++++++++++--------------------
> 1 files changed, 46 insertions(+), 52 deletions(-)
>
> diff --git a/arch/powerpc/kernel/prom_parse.c b/arch/powerpc/kernel/prom_parse.c
> index 90eb3a3..7c6b07c 100644
> --- a/arch/powerpc/kernel/prom_parse.c
> +++ b/arch/powerpc/kernel/prom_parse.c
> @@ -31,21 +25,19 @@ static int __of_address_to_resource(struct device_node *dev,
> const u32 *addrp, u64 size, unsigned int flags,
> struct resource *r);
>
> -
> /* Debug utility */
> #ifdef DEBUG
> static void of_dump_addr(const char *s, const u32 *addr, int na)
> {
> - printk("%s", s);
> - while(na--)
> - printk(" %08x", *(addr++));
> - printk("\n");
> + printk(KERN_INFO "%s", s);
> + while (na--)
> + printk(KERN_INFO " %08x", *(addr++));
> + printk(KERN_INFO "\n");
This is wrong you'll get
string <6> XXXXXXXX <6> XXXXXXX ... <6>
next prev parent reply other threads:[~2008-05-03 17:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-03 15:13 Clean PROM_PARSE.C file monstr
2008-05-03 15:13 ` [PATCH 1/2] OF: clean coding style - prom_parse.c monstr
2008-05-03 15:13 ` [PATCH 2/2] OF: move prom_parse to drivers/of folder monstr
2008-05-03 17:25 ` Jiri Slaby [this message]
2008-05-03 17:26 ` [PATCH 1/2] OF: clean coding style - prom_parse.c Joe Perches
2008-05-04 8:17 ` Michal Simek
2008-05-04 15:51 ` Jiri Slaby
2008-05-04 16:18 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=481C9FFB.3090207@gmail.com \
--to=jirislaby@gmail.com \
--cc=arnd@arndb.de \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=monstr@monstr.eu \
--cc=monstr@seznam.cz \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox