From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michal Simek Subject: Re: [PATCH 17/56] microblaze_v2: checksum support Date: Mon, 05 May 2008 16:05:08 +0200 Message-ID: <481F1414.6020203@seznam.cz> References: <1209901305-6404-1-git-send-email-monstr@seznam.cz> <625ef466cf121d655539eedc919dd39166087e0c.1209897266.git.monstr@monstr.eu> <200805042159.55077.arnd@arndb.de> Reply-To: monstr@seznam.cz Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Return-path: Received: from smtp1.wifiinternet.cz ([89.31.47.1]:57184 "EHLO bor.wifiinternet.cz" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752032AbYEEOEI (ORCPT ); Mon, 5 May 2008 10:04:08 -0400 In-Reply-To: <200805042159.55077.arnd@arndb.de> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Arnd Bergmann Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, stephen.neuendorffer@xilinx.com, John.Linn@xilinx.com, john.williams@petalogix.com, matthew@wil.cx, will.newton@gmail.com, drepper@redhat.com, microblaze-uclinux@itee.uq.edu.au, grant.likely@secretlab.ca, Michal Simek Hi, >> + * >> + * INET An implementation of the TCP/IP protocol suite for the LINUX >> + * operating system. INET is implemented using the BSD Socket >> + * interface as the means of communication with the user level. >> + * >> + * IP/TCP/UDP checksumming routines >> + * >> + * Authors: Jorge Cwik, >> + * Arnt Gulbrandsen, >> + * Tom May, >> + * Andreas Schwab, >> + * Lots of code moved from tcp.c and ip.c; see those files >> + * for more names. > > This is a pretty generic implementation, and you copied it from another > architecture. How about moving it from arch/microblaze/lib/ to lib/? > I'd suggest building it conditionally under CONFIG_GENERIC_CSUM, > which you def_bool in your architecture Kconfig. > > Arnd <>< I move checksum.c to /lib and checksum.h to asm-generic and add to GENERIC_CSUM to Kconfig 6 config MICROBLAZE 7 def_bool y 8 select HAVE_LMB 9 select GENERIC_CSUM M