public inbox for linux-arch@vger.kernel.org
 help / color / mirror / Atom feed
From: Michal Simek <monstr@seznam.cz>
To: Stephen Neuendorffer <stephen.neuendorffer@xilinx.com>
Cc: arnd@arndb.de, linux-arch@vger.kernel.org,
	John Linn <linnj@xilinx.com>,
	john.williams@petalogix.com, matthew@wil.cx,
	will.newton@gmail.com, drepper@redhat.com,
	microblaze-uclinux@itee.uq.edu.au, grant.likely@secretlab.ca,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Microblaze: implement dma-coherent API and refactor cache flush code.
Date: Tue, 06 May 2008 11:28:22 +0200	[thread overview]
Message-ID: <482024B6.5070704@seznam.cz> (raw)
In-Reply-To: <20080505223706.1236C1C8004E@mail131-sin.bigfish.com>

Hi Steve,

>  arch/microblaze/kernel/cpu/cache.c  |   37 +---------
>  arch/microblaze/kernel/setup.c      |    4 +-
>  arch/microblaze/mm/dma-coherent.c   |  122

dma-coherent.c is dead for now.

> diff --git a/arch/microblaze/kernel/setup.c
> b/arch/microblaze/kernel/setup.c
> index 43d53d9..241fb21 100644
> --- a/arch/microblaze/kernel/setup.c
> +++ b/arch/microblaze/kernel/setup.c
> @@ -51,10 +51,10 @@ void __init setup_arch(char **cmdline_p)
>  	/* irq_early_init(); */
>  	setup_cpuinfo();
>  
> -	__flush_icache_all();
> +	__invalidate_icache_all();
>  	__enable_icache();
>  
> -	__flush_dcache_all();
> +	__invalidate_icache_all();
>  	__enable_dcache();

here is bug.

>  	panic_timeout = 120;
> diff --git a/arch/microblaze/mm/dma-coherent.c
> b/arch/microblaze/mm/dma-coherent.c

removed.

M

      parent reply	other threads:[~2008-05-06  9:27 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-05 22:37 [PATCH] Microblaze: implement dma-coherent API and refactor cache flush code Stephen Neuendorffer
2008-05-05 22:37 ` Stephen Neuendorffer
2008-05-05 22:57 ` John Williams
2008-05-05 23:12   ` [PATCH] Microblaze: implement dma-coherent API and refactorcache " Stephen Neuendorffer
2008-05-06  0:14     ` John Williams
2008-05-06  0:31       ` [PATCH] Microblaze: implement dma-coherent API andrefactorcache " Stephen Neuendorffer
2008-05-06  7:23         ` Geert Uytterhoeven
2008-05-06  9:33           ` Michal Simek
2008-05-06  9:28 ` Michal Simek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=482024B6.5070704@seznam.cz \
    --to=monstr@seznam.cz \
    --cc=arnd@arndb.de \
    --cc=drepper@redhat.com \
    --cc=grant.likely@secretlab.ca \
    --cc=john.williams@petalogix.com \
    --cc=linnj@xilinx.com \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matthew@wil.cx \
    --cc=microblaze-uclinux@itee.uq.edu.au \
    --cc=stephen.neuendorffer@xilinx.com \
    --cc=will.newton@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox