From: Michal Simek <monstr@seznam.cz>
To: Paul Mackerras <paulus@samba.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
John Williams <john.williams@petalogix.com>,
Matthew Wilcox <matthew@wil.cx>,
Will Newton <will.newton@gmail.com>,
Linux Kernel list <linux-kernel@vger.kernel.org>,
linux-arch@vger.kernel.org, git@xilinx.com,
Stephen Neuendorffer <stephen.neuendorffer@xilinx.com>,
John Linn <John.Linn@xilinx.com>,
Ulrich Drepper <drepper@redhat.com>
Subject: Re: OF files
Date: Sun, 11 May 2008 15:59:20 +0200 [thread overview]
Message-ID: <4826FBB8.7060107@seznam.cz> (raw)
In-Reply-To: <18467.60177.91772.136339@cargo.ozlabs.ibm.com>
Hi All,
I move prom_parse.c to drivers/of.
of_platform.c was completely moved to drivers/of/platform.c
Functions from of_device.c was moved to drivers/of/device.c except
of_device_make_bus_id.
Prom.c file was cleaned - I remove all PPC specific code.
You can check it in my git tree (git.monstr.eu) or wait for next set of patches.
Michal
> Michal Simek writes:
>
>> I tested OF files changes. I sent you some patches about.
>>
>> I look at headers files too. Is it possible to move prom.h,
>> of_device.h and of_platform.h to asm-generic or linux folder?
>
> We can move stuff to drivers/of and include/linux, but we should only
> move the parts that are truly architecture-independent. We should not
> have anything like #ifdef CONFIG_PPC_PSERIES in the files in those
> directories. If it needs an ifdef like that, then that part of the
> file should stay under arch/powerpc.
>
> In other words, it's OK to split files and end up with more files than
> we have at present. That's better than adding ifdefs.
>
> Paul.
>
prev parent reply other threads:[~2008-05-11 13:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-03 15:30 OF files Michal Simek
2008-05-03 15:30 ` Michal Simek
2008-05-05 0:14 ` Stephen Rothwell
2008-05-09 6:11 ` Paul Mackerras
2008-05-11 13:59 ` Michal Simek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4826FBB8.7060107@seznam.cz \
--to=monstr@seznam.cz \
--cc=John.Linn@xilinx.com \
--cc=arnd@arndb.de \
--cc=drepper@redhat.com \
--cc=git@xilinx.com \
--cc=john.williams@petalogix.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=paulus@samba.org \
--cc=stephen.neuendorffer@xilinx.com \
--cc=will.newton@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox