* OF files
2008-05-03 15:30 OF files Michal Simek
@ 2008-05-03 15:30 ` Michal Simek
2008-05-05 0:14 ` Stephen Rothwell
2008-05-09 6:11 ` Paul Mackerras
2 siblings, 0 replies; 5+ messages in thread
From: Michal Simek @ 2008-05-03 15:30 UTC (permalink / raw)
To: Arnd Bergmann, John Williams, Matthew Wilcox, Will Newton,
Linux Kernel list, linux-arch, git, Stephen Neuendorffer,
John Linn, Ulrich Drepper, paulus
Hi Paulus and others,
I tested OF files changes. I sent you some patches about.
I look at headers files too. Is it possible to move prom.h, of_device.h and of_platform.h to asm-generic or linux folder?
Thanks,
Michal Simek
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: OF files
2008-05-03 15:30 OF files Michal Simek
2008-05-03 15:30 ` Michal Simek
@ 2008-05-05 0:14 ` Stephen Rothwell
2008-05-09 6:11 ` Paul Mackerras
2 siblings, 0 replies; 5+ messages in thread
From: Stephen Rothwell @ 2008-05-05 0:14 UTC (permalink / raw)
To: Michal Simek
Cc: Arnd Bergmann, John Williams, Matthew Wilcox, Will Newton,
Linux Kernel list, linux-arch, git, Stephen Neuendorffer,
John Linn, Ulrich Drepper, paulus
[-- Attachment #1: Type: text/plain, Size: 625 bytes --]
Hi Michal,
On Sat, 03 May 2008 17:30:41 +0200 (CEST) Michal Simek <Monstr@seznam.cz> wrote:
>
> Hi Paulus and others,
>
> I tested OF files changes. I sent you some patches about.
>
> I look at headers files too. Is it possible to move prom.h, of_device.h
> and of_platform.h to asm-generic or linux folder?
We already have include/linux/of_{device,platform}.h. prom.h is mostly
powerpc specific - you should either create your own prom.h, or suggest
stuff that needs to be moved into linux/of.h.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: OF files
2008-05-03 15:30 OF files Michal Simek
2008-05-03 15:30 ` Michal Simek
2008-05-05 0:14 ` Stephen Rothwell
@ 2008-05-09 6:11 ` Paul Mackerras
2008-05-11 13:59 ` Michal Simek
2 siblings, 1 reply; 5+ messages in thread
From: Paul Mackerras @ 2008-05-09 6:11 UTC (permalink / raw)
To: Michal Simek
Cc: Arnd Bergmann, John Williams, Matthew Wilcox, Will Newton,
Linux Kernel list, linux-arch, git, Stephen Neuendorffer,
John Linn, Ulrich Drepper
Michal Simek writes:
> I tested OF files changes. I sent you some patches about.
>
> I look at headers files too. Is it possible to move prom.h,
> of_device.h and of_platform.h to asm-generic or linux folder?
We can move stuff to drivers/of and include/linux, but we should only
move the parts that are truly architecture-independent. We should not
have anything like #ifdef CONFIG_PPC_PSERIES in the files in those
directories. If it needs an ifdef like that, then that part of the
file should stay under arch/powerpc.
In other words, it's OK to split files and end up with more files than
we have at present. That's better than adding ifdefs.
Paul.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: OF files
2008-05-09 6:11 ` Paul Mackerras
@ 2008-05-11 13:59 ` Michal Simek
0 siblings, 0 replies; 5+ messages in thread
From: Michal Simek @ 2008-05-11 13:59 UTC (permalink / raw)
To: Paul Mackerras
Cc: Arnd Bergmann, John Williams, Matthew Wilcox, Will Newton,
Linux Kernel list, linux-arch, git, Stephen Neuendorffer,
John Linn, Ulrich Drepper
Hi All,
I move prom_parse.c to drivers/of.
of_platform.c was completely moved to drivers/of/platform.c
Functions from of_device.c was moved to drivers/of/device.c except
of_device_make_bus_id.
Prom.c file was cleaned - I remove all PPC specific code.
You can check it in my git tree (git.monstr.eu) or wait for next set of patches.
Michal
> Michal Simek writes:
>
>> I tested OF files changes. I sent you some patches about.
>>
>> I look at headers files too. Is it possible to move prom.h,
>> of_device.h and of_platform.h to asm-generic or linux folder?
>
> We can move stuff to drivers/of and include/linux, but we should only
> move the parts that are truly architecture-independent. We should not
> have anything like #ifdef CONFIG_PPC_PSERIES in the files in those
> directories. If it needs an ifdef like that, then that part of the
> file should stay under arch/powerpc.
>
> In other words, it's OK to split files and end up with more files than
> we have at present. That's better than adding ifdefs.
>
> Paul.
>
^ permalink raw reply [flat|nested] 5+ messages in thread