From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Ungerer Subject: Re: [PATCH 29/31] binfmt_flat: use flush_icache_user_range Date: Wed, 13 May 2020 00:46:55 +1000 Message-ID: <484af2c0-2450-b40a-8322-e691495c45aa@linux-m68k.org> References: <20200510075510.987823-1-hch@lst.de> <20200510075510.987823-30-hch@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20200510075510.987823-30-hch@lst.de> Content-Language: en-US Sender: linux-ia64-owner@vger.kernel.org To: Christoph Hellwig , Andrew Morton , Arnd Bergmann , Roman Zippel Cc: Jessica Yu , Michal Simek , x86@kernel.org, linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-c6x-dev@linux-c6x.org, linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, openrisc@lists.librecores.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, linux-fsdevel@vger.kernel.org List-Id: linux-arch.vger.kernel.org Hi Christoph, On 10/5/20 5:55 pm, Christoph Hellwig wrote: > load_flat_file works on user addresses. > > Signed-off-by: Christoph Hellwig Acked-by: Greg Ungerer Regards Greg > --- > fs/binfmt_flat.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/binfmt_flat.c b/fs/binfmt_flat.c > index 831a2b25ba79f..6f0aca5379da2 100644 > --- a/fs/binfmt_flat.c > +++ b/fs/binfmt_flat.c > @@ -854,7 +854,7 @@ static int load_flat_file(struct linux_binprm *bprm, > #endif /* CONFIG_BINFMT_FLAT_OLD */ > } > > - flush_icache_range(start_code, end_code); > + flush_icache_user_range(start_code, end_code); > > /* zero the BSS, BRK and stack areas */ > if (clear_user((void __user *)(datapos + data_len), bss_len + > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.kernel.org ([198.145.29.99]:36974 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727099AbgELOrH (ORCPT ); Tue, 12 May 2020 10:47:07 -0400 Subject: Re: [PATCH 29/31] binfmt_flat: use flush_icache_user_range References: <20200510075510.987823-1-hch@lst.de> <20200510075510.987823-30-hch@lst.de> From: Greg Ungerer Message-ID: <484af2c0-2450-b40a-8322-e691495c45aa@linux-m68k.org> Date: Wed, 13 May 2020 00:46:55 +1000 MIME-Version: 1.0 In-Reply-To: <20200510075510.987823-30-hch@lst.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: Christoph Hellwig , Andrew Morton , Arnd Bergmann , Roman Zippel Cc: Jessica Yu , Michal Simek , x86@kernel.org, linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-c6x-dev@linux-c6x.org, linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, openrisc@lists.librecores.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, linux-fsdevel@vger.kernel.org Message-ID: <20200512144655.qoGxdzWeqbGKS28dn1l08zxxlXDGa3BBMEgpRSNBihQ@z> Hi Christoph, On 10/5/20 5:55 pm, Christoph Hellwig wrote: > load_flat_file works on user addresses. > > Signed-off-by: Christoph Hellwig Acked-by: Greg Ungerer Regards Greg > --- > fs/binfmt_flat.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/binfmt_flat.c b/fs/binfmt_flat.c > index 831a2b25ba79f..6f0aca5379da2 100644 > --- a/fs/binfmt_flat.c > +++ b/fs/binfmt_flat.c > @@ -854,7 +854,7 @@ static int load_flat_file(struct linux_binprm *bprm, > #endif /* CONFIG_BINFMT_FLAT_OLD */ > } > > - flush_icache_range(start_code, end_code); > + flush_icache_user_range(start_code, end_code); > > /* zero the BSS, BRK and stack areas */ > if (clear_user((void __user *)(datapos + data_len), bss_len + >