From mboxrd@z Thu Jan 1 00:00:00 1970 From: "H. Peter Anvin" Subject: Re: [PATCH 48/60] microblaze_v4: headers simple files - empty or redirect to asm-generic Date: Thu, 26 Jun 2008 10:57:19 -0700 Message-ID: <4863D87F.5060103@zytor.com> References: <1214483429-32360-1-git-send-email-monstr@seznam.cz> <200806261735.12738.arnd@arndb.de> <20080626162118.GG22025@cs181140183.pp.htv.fi> <200806261838.33787.arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <200806261838.33787.arnd@arndb.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linuxppc-dev-bounces+glppd-linuxppc64-dev=m.gmane.org@ozlabs.org Errors-To: linuxppc-dev-bounces+glppd-linuxppc64-dev=m.gmane.org@ozlabs.org To: Arnd Bergmann Cc: linux-arch@vger.kernel.org, alan@lxorguk.ukuu.org.uk, Adrian Bunk , vapier.adi@gmail.com, matthew@wil.cx, microblaze-uclinux@itee.uq.edu.au, linux-kernel@vger.kernel.org, drepper@redhat.com, linuxppc-dev@ozlabs.org, will.newton@gmail.com, Michal Simek , monstr@seznam.cz, John.Linn@xilinx.com, john.williams@petalogix.com List-Id: linux-arch.vger.kernel.org Arnd Bergmann wrote: > On Thursday 26 June 2008, Adrian Bunk wrote: >> The comment could be nuked (as well as the #ifdef __KERNEL__), but for >> the one #define an asm-generic header would IMHO be overkill. > > I agree that it doesn't technically make sense to have a one-line > asm-generic header, but I like the idea of reducing the number of > asm/*.h files that actually contain anything other that > #include , mostly for documentation purposes. > > If we can eventually agree on a way to get rid of the requirement > for explicit redirection, we can remove a larger number of source > files completely. > The sanest way to do that would probably be something along the lines of: -> Change include/asm-xxx to arch/xxx/include/asm -> Create arch/generic -> Make sure arch/xxx/include/asm and arch/generic/include/asm are both in the include path, in that order. That would also get rid of the symlink. On the other hand, the redirection isn't all that bad. -hpa From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from terminus.zytor.com ([198.137.202.10]:52963 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753636AbYFZSE1 (ORCPT ); Thu, 26 Jun 2008 14:04:27 -0400 Message-ID: <4863D87F.5060103@zytor.com> Date: Thu, 26 Jun 2008 10:57:19 -0700 From: "H. Peter Anvin" MIME-Version: 1.0 Subject: Re: [PATCH 48/60] microblaze_v4: headers simple files - empty or redirect to asm-generic References: <1214483429-32360-1-git-send-email-monstr@seznam.cz> <200806261735.12738.arnd@arndb.de> <20080626162118.GG22025@cs181140183.pp.htv.fi> <200806261838.33787.arnd@arndb.de> In-Reply-To: <200806261838.33787.arnd@arndb.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: Arnd Bergmann Cc: Adrian Bunk , monstr@seznam.cz, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, stephen.neuendorffer@xilinx.com, John.Linn@xilinx.com, john.williams@petalogix.com, matthew@wil.cx, will.newton@gmail.com, drepper@redhat.com, microblaze-uclinux@itee.uq.edu.au, grant.likely@secretlab.ca, linuxppc-dev@ozlabs.org, vapier.adi@gmail.com, alan@lxorguk.ukuu.org.uk, Michal Simek Message-ID: <20080626175719.aDNqCbeLaNisYcKxpcU6nITTQh8ND7YfWqEqySlxEv8@z> Arnd Bergmann wrote: > On Thursday 26 June 2008, Adrian Bunk wrote: >> The comment could be nuked (as well as the #ifdef __KERNEL__), but for >> the one #define an asm-generic header would IMHO be overkill. > > I agree that it doesn't technically make sense to have a one-line > asm-generic header, but I like the idea of reducing the number of > asm/*.h files that actually contain anything other that > #include , mostly for documentation purposes. > > If we can eventually agree on a way to get rid of the requirement > for explicit redirection, we can remove a larger number of source > files completely. > The sanest way to do that would probably be something along the lines of: -> Change include/asm-xxx to arch/xxx/include/asm -> Create arch/generic -> Make sure arch/xxx/include/asm and arch/generic/include/asm are both in the include path, in that order. That would also get rid of the symlink. On the other hand, the redirection isn't all that bad. -hpa