From: Greg Ungerer <gerg@snapgear.com>
To: Johannes Weiner <hannes@saeurebad.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
Geert Uytterhoeven <geert@linux-m68k.org>
Subject: Re: [PATCH 16/20] m68knommu: use generic show_mem()
Date: Sun, 06 Jul 2008 13:34:43 +1000 [thread overview]
Message-ID: <48703D53.7000402@snapgear.com> (raw)
In-Reply-To: <20080704161457.056057813@saeurebad.de>
Johannes Weiner wrote:
> Remove arch-specific show_mem() in favor of the generic version.
>
> This also removes the following redundant information display:
>
> - free pages, printed by show_free_areas()
> - pages in swapcache, printed by show_swap_cache_info()
>
> where show_mem() calls show_free_areas(), which calls
> show_swap_cache_info().
>
> Signed-off-by: Johannes Weiner <hannes@saeurebad.de>
> CC: Geert Uytterhoeven <geert@linux-m68k.org>
Acked-by: Greg Ungerer <gerg@uclinux.org>
> ---
> arch/m68knommu/mm/init.c | 27 ---------------------------
> 1 file changed, 27 deletions(-)
>
> --- a/arch/m68knommu/mm/init.c
> +++ b/arch/m68knommu/mm/init.c
> @@ -62,33 +62,6 @@ static unsigned long empty_bad_page;
>
> unsigned long empty_zero_page;
>
> -void show_mem(void)
> -{
> - unsigned long i;
> - int free = 0, total = 0, reserved = 0, shared = 0;
> - int cached = 0;
> -
> - printk(KERN_INFO "\nMem-info:\n");
> - show_free_areas();
> - i = max_mapnr;
> - while (i-- > 0) {
> - total++;
> - if (PageReserved(mem_map+i))
> - reserved++;
> - else if (PageSwapCache(mem_map+i))
> - cached++;
> - else if (!page_count(mem_map+i))
> - free++;
> - else
> - shared += page_count(mem_map+i) - 1;
> - }
> - printk(KERN_INFO "%d pages of RAM\n",total);
> - printk(KERN_INFO "%d free pages\n",free);
> - printk(KERN_INFO "%d reserved pages\n",reserved);
> - printk(KERN_INFO "%d pages shared\n",shared);
> - printk(KERN_INFO "%d pages swap cached\n",cached);
> -}
> -
> extern unsigned long memory_start;
> extern unsigned long memory_end;
>
--
------------------------------------------------------------------------
Greg Ungerer -- Chief Software Dude EMAIL: gerg@snapgear.com
Secure Computing Corporation PHONE: +61 7 3435 2888
825 Stanley St, FAX: +61 7 3891 3630
Woolloongabba, QLD, 4102, Australia WEB: http://www.SnapGear.com
next prev parent reply other threads:[~2008-07-06 3:34 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-04 16:07 [PATCH 00/20] generic show_mem() v5 Johannes Weiner
2008-07-04 16:07 ` [PATCH 01/20] mm: print swapcache page count in show_swap_cache_info() Johannes Weiner
2008-07-04 16:07 ` [PATCH 02/20] lib: generic show_mem() Johannes Weiner
2008-07-05 8:34 ` Heiko Carstens
2008-07-05 11:29 ` Johannes Weiner
2008-07-05 11:54 ` Heiko Carstens
2008-07-04 16:07 ` [PATCH 03/20] alpha: use " Johannes Weiner
2008-07-04 16:07 ` [PATCH 04/20] avr32: " Johannes Weiner
2008-07-04 16:07 ` [PATCH 05/20] blackfin: " Johannes Weiner
2008-07-04 16:07 ` [PATCH 06/20] xtensa: " Johannes Weiner
2008-07-04 16:07 ` [PATCH 07/20] x86: " Johannes Weiner
2008-07-04 16:07 ` [PATCH 08/20] um: " Johannes Weiner
2008-07-04 16:07 ` [PATCH 09/20] sparc64: " Johannes Weiner
2008-07-04 16:07 ` [PATCH 10/20] sh: " Johannes Weiner
2008-07-04 16:07 ` [PATCH 11/20] s390: " Johannes Weiner
2008-07-04 16:07 ` [PATCH 12/20] powerpc: " Johannes Weiner
2008-07-04 16:07 ` [PATCH 13/20] mn10300: " Johannes Weiner
2008-07-04 16:07 ` [PATCH 14/20] h8300: " Johannes Weiner
2008-07-04 16:07 ` [PATCH 15/20] mips: " Johannes Weiner
2008-07-04 16:07 ` [PATCH 16/20] m68knommu: " Johannes Weiner
2008-07-05 8:11 ` Geert Uytterhoeven
2008-07-05 11:30 ` Johannes Weiner
2008-07-05 12:10 ` Johannes Weiner
2008-07-06 3:34 ` Greg Ungerer [this message]
2008-07-06 3:34 ` Greg Ungerer
2008-07-04 16:07 ` [PATCH 17/20] m68k: " Johannes Weiner
2008-07-04 16:07 ` [PATCH 18/20] m32r: " Johannes Weiner
2008-07-04 16:07 ` [PATCH 19/20] frv: " Johannes Weiner
2008-07-04 16:07 ` [PATCH 20/20] cris: " Johannes Weiner
2008-07-04 16:07 ` Johannes Weiner
2008-07-15 19:06 ` [PATCH 00/20] generic show_mem() v5 Dave Hansen
2008-07-15 19:06 ` Dave Hansen
2008-07-15 20:22 ` Andrew Morton
2008-07-15 20:22 ` Andrew Morton
2008-07-15 20:33 ` Dave Hansen
2008-07-16 21:51 ` Dave Hansen
2008-07-16 22:06 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48703D53.7000402@snapgear.com \
--to=gerg@snapgear.com \
--cc=akpm@linux-foundation.org \
--cc=geert@linux-m68k.org \
--cc=hannes@saeurebad.de \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).