From mboxrd@z Thu Jan 1 00:00:00 1970 From: "H. Peter Anvin" Subject: Re: [PATCH 11/14] x86: Populate cpu_enabled_map Date: Fri, 18 Jul 2008 13:00:23 -0700 Message-ID: <4880F657.8050508@zytor.com> References: <20080715025656.GC15452@ldl.fc.hp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20080715025656.GC15452@ldl.fc.hp.com> Sender: linux-kernel-owner@vger.kernel.org To: Alex Chiang , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-acpi@vger.kernel.org, Ingo Molnar , Thomas Gleixner List-Id: linux-arch.vger.kernel.org Alex Chiang wrote: > Populate the cpu_enabled_map correctly. > > Note that this patch does not actually make any decisions based > on the contents of the map. > > However, as the map is presented via sysfs in: > > /sys/devices/system/cpu/ > > It should be populated correctly. > > There will be a user-visible change under the above directory. > cpuN/ entries for firmware-disabled CPUs will now appear, whereas > before, they did not due to a check against ACPI_MADT_ENABLED. > > The cpuN/ entries will be empty, and the online file in the > above directory will reflect which CPUs are actually schedulable. > > Signed-off-by: Alex Chiang > Cc: Ingo Molnar > Cc: Thomas Gleixner > Cc: H. Peter Anvin From an x86 standpoint this patchset seems reasonable to me. Acked-by: H. Peter Anvin Since it is a panarch patchset it presumably should go via -mm rather than in the arch trees, so I'm not going to add it to -tip. Obviously, if the sematics of the operations don't make sense for other architectures -- which I will leave up to the affected maintainers -- then that should be carefully considered if the generic operations can be done better. -hpa From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from terminus.zytor.com ([198.137.202.10]:53504 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756622AbYGRUAy (ORCPT ); Fri, 18 Jul 2008 16:00:54 -0400 Message-ID: <4880F657.8050508@zytor.com> Date: Fri, 18 Jul 2008 13:00:23 -0700 From: "H. Peter Anvin" MIME-Version: 1.0 Subject: Re: [PATCH 11/14] x86: Populate cpu_enabled_map References: <20080715025656.GC15452@ldl.fc.hp.com> In-Reply-To: <20080715025656.GC15452@ldl.fc.hp.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: Alex Chiang , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-acpi@vger.kernel.org, Ingo Molnar , Thomas Gleixner , hpa@zytor.com Message-ID: <20080718200023.gUpQzrLHn39xjg9MhpgK9Shof62nTJ6Szgdl7xEJscA@z> Alex Chiang wrote: > Populate the cpu_enabled_map correctly. > > Note that this patch does not actually make any decisions based > on the contents of the map. > > However, as the map is presented via sysfs in: > > /sys/devices/system/cpu/ > > It should be populated correctly. > > There will be a user-visible change under the above directory. > cpuN/ entries for firmware-disabled CPUs will now appear, whereas > before, they did not due to a check against ACPI_MADT_ENABLED. > > The cpuN/ entries will be empty, and the online file in the > above directory will reflect which CPUs are actually schedulable. > > Signed-off-by: Alex Chiang > Cc: Ingo Molnar > Cc: Thomas Gleixner > Cc: H. Peter Anvin From an x86 standpoint this patchset seems reasonable to me. Acked-by: H. Peter Anvin Since it is a panarch patchset it presumably should go via -mm rather than in the arch trees, so I'm not going to add it to -tip. Obviously, if the sematics of the operations don't make sense for other architectures -- which I will leave up to the affected maintainers -- then that should be carefully considered if the generic operations can be done better. -hpa