Re: [PATCH 10/73] powerpc: use device_initcall for registering rtc devices

Paul Gortmaker
2014-01-22T02:27:24Z

On Tue, Jan 21, 2014 at 6:48 PM, Geoff Levand <geoff@infradead.org> wrote:
> Hi Paul,
>
> On Tue, 2014-01-21 at 16:22 -0500, Paul Gortmaker wrote:
>> Currently these two RTC devices are in core platform code
>> where it is not possible for them to be modular. It will
>> never be modular, so using module_init as an alias for
>> __initcall can be somewhat misleading.
>>
>> arch/powerpc/kernel/time.c | 2 +-
>> arch/powerpc/platforms/ps3/time.c | 3 +--
>> 2 files changed, 2 insertions(+), 3 deletions(-)
>
> I tested the PS3 part of this patch and it seems to work OK.
>
> Acked-by: Geoff Levand <geoff@infradead.org>

Thanks Geoff for the review and testing; I'll add the ack.

Paul.
--

>
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/linuxppc-dev