Re: [PATCH 31/73] module: relocate module_init from init.h to module.h

Paul Gortmaker
2014-01-22T01:56:55Z

On Tue, Jan 21, 2014 at 7:16 PM, Rusty Russell <rusty@rustcorp.com.au> wrote:
> Paul Gortmaker <paul.gortmaker@windriver.com> writes:
>> Modular users will always be users of init functionality, but
>> users of init functionality are not necessarily always modules.
>>
>> Hence any functionality like module_init and module_exit would
>> be more at home in the module.h file. And module.h should
>> explicitly include init.h to make the dependency clear.
>>
>> We've already done all the legwork needed to ensure that this
>> move does not cause any build regressions due to implicit
>> header file include assumptions about where module_init lives.
>>
>> Cc: Rusty Russell <rusty@rustcorp.com.au>
>> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
>
> Acked-by: Rusty Russell <rusty@rustcorp.com.au>
>
> Want to delete the extraneous semicolons, for bonus points? :)
>
>> +#define module_init(x) __initcall(x);

I would if I could, but as I was discussing on irc with hpa about a
week ago, there are ~600 users of module_init who are relying on
that extra ";" that we need to fix 1st... :-) [on my todo list!]

Thanks for the review; much appreciated,
Paul.
--

> ...
>> +#define module_exit(x) __exitcall(x);
>
> Cheers,
> Rusty.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-arch" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html