From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93714C433F5 for ; Thu, 5 May 2022 23:17:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1386667AbiEEXUp (ORCPT ); Thu, 5 May 2022 19:20:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56912 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1386669AbiEEXUo (ORCPT ); Thu, 5 May 2022 19:20:44 -0400 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 37E41606D4; Thu, 5 May 2022 16:16:50 -0700 (PDT) Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 245Mnxix013484; Thu, 5 May 2022 23:15:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2021-07-09; bh=vK/69g9gAGOO/9wmiHBkCC73hyaFxyrsuRV/WYIOenM=; b=sk2SySZG5ZR2bBA7R+owbrXhrwc712jVz3d0tGRpQCDCPKq5X9bOldA8bUAyLmGWCOVl j2XmynUiFRqSBL+3NQtcWUtDDuLxK4Pe0GToHjfbyxovrlZuaNGBcMEh7jdeV53fdlbe 6u3ZP9/8AG9Toe8e7KIGA/oavSdTglLJ07i+mpyr6KzjGTn8YfQvb2zVB0K0e8kxIkZN YVXlSKBoA76AMDNQyHwSq/Iyfv2xp+9Uex7ON7TTNWIPygniK1T+oHwOp4l7e5JWPLfU p0QP0Z6PG2/jojPfy14fW0gwk1pogEkm2tCiFTO5cMss51cg0imWQkr7EMOHnfyVKvL6 UA== Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3frvqsms03-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 05 May 2022 23:15:33 +0000 Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.16.1.2/8.16.1.2) with SMTP id 245NBOgS011959; Thu, 5 May 2022 23:15:32 GMT Received: from nam10-dm6-obe.outbound.protection.outlook.com (mail-dm6nam10lp2105.outbound.protection.outlook.com [104.47.58.105]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com with ESMTP id 3fs1a7mt9e-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 05 May 2022 23:15:32 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WzlzTdBTOSrkELf54SlRmL0+pYWC5j+P1Rk7iIygEYXeNWiXm2erhKILzkyjNK3VP33Jf0Ysq2FYazkjv3wHqrVw94SYAGy4WW0kQMn75L1PmzU48KrtV3rQFlyDNaf6O/FO2lyt0VNNiHi222WXr9x1S55MGXDYEOosupGjM4bQoL0co9/PrI4EijuExDQifk8AqSgl9xCdvTAWyX4IQP32g1XDFR1M7/sV3UxYCTiafs2jVq9g9qkmc1RYF+w1JgmwjtY134ed91KJjkZbOT7F7S6Fh7K8xbnnYqsZky6OXuLlr4gFhn/eMdMuhwt79hbIN666hrjbsabF1k/kLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vK/69g9gAGOO/9wmiHBkCC73hyaFxyrsuRV/WYIOenM=; b=hLtGhd3dnJi+Of2rC7LBC7ak6WFkoELECvzrqG90lFZwtAqhGpoM5emBFq0lhng3eositM39ANOHyDS+uSx3M26qOaDKjABRZaZIy5/Pk+ZkzvCurjTa3ru9kGJvSVc9ECb8sC52FSe0mnZgbx+7H2y3YhrJ19T5vjTdZ7rgmBLrEhMit3rl/ygyD6c7aVwARelEAk9C2oC6zSy1tZJ2NYz7bGYFECQTCbsD+XZ5Mxx1o9adNKUy0ftZVv+Ype8Mu36dcamQbig932bYJ2wm7H6hxYAAgXJgR6uOPK1FiDbbnWz9ReyKDi2zRmArv7q48WOVgzmHTeBxrSjw1QTQkg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vK/69g9gAGOO/9wmiHBkCC73hyaFxyrsuRV/WYIOenM=; b=L/xjgzYjRqIdoH25QZbO4DS6yLFI1XEFFVAWQz5C9j6Q6YMk/4eDi3KNIj0I25qCeJBueBRiSLFs8LMcSCsqwEaaz9/BGUr7I3TEeKzDTnUFwCP1+dL5f7EHFW1GtfQIVwDiWZBCdCZCaLNHgiYWWLmQVCdoPfNwy2bn6m8Im4I= Received: from BY5PR10MB4196.namprd10.prod.outlook.com (2603:10b6:a03:20d::23) by CH0PR10MB4874.namprd10.prod.outlook.com (2603:10b6:610:c5::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.24; Thu, 5 May 2022 23:15:30 +0000 Received: from BY5PR10MB4196.namprd10.prod.outlook.com ([fe80::9d76:7926:9b76:f461]) by BY5PR10MB4196.namprd10.prod.outlook.com ([fe80::9d76:7926:9b76:f461%7]) with mapi id 15.20.5206.024; Thu, 5 May 2022 23:15:30 +0000 Message-ID: <495c4ebe-a5b4-afb6-4cb0-956c1b18d0cc@oracle.com> Date: Thu, 5 May 2022 16:15:26 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH 1/3] mm: change huge_ptep_clear_flush() to return the original pte Content-Language: en-US To: Baolin Wang , akpm@linux-foundation.org, catalin.marinas@arm.com, will@kernel.org Cc: tsbogend@alpha.franken.de, James.Bottomley@HansenPartnership.com, deller@gmx.de, mpe@ellerman.id.au, benh@kernel.crashing.org, paulus@samba.org, hca@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com, borntraeger@linux.ibm.com, svens@linux.ibm.com, ysato@users.sourceforge.jp, dalias@libc.org, davem@davemloft.net, arnd@arndb.de, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org References: From: Mike Kravetz In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: MW4PR03CA0028.namprd03.prod.outlook.com (2603:10b6:303:8f::33) To BY5PR10MB4196.namprd10.prod.outlook.com (2603:10b6:a03:20d::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4003ceb6-f24f-4649-eb93-08da2eed2576 X-MS-TrafficTypeDiagnostic: CH0PR10MB4874:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kK6gJkABkwTtZalxWLTzbLZkOCRhLiPr58k9SMXoV575o1eKMjzsSpkAv50/V7l1Clv5cGfaRRNtv/v8XBttyIU0WBvkmZ0eM8nJcHsrVEaOuH958tmIJnySLpGqCEc2JTAmbwkRtb3mVzMaoNVyDJ6TuvaJOvTQbhm4Dt+2/TjoEoRL4jczs9e/HbZVvgCTtC288/59mXfSNBM24CyGMC3jf3bhvfDi7u5E6MXUsX3OXgvj+ZwtbMDHXNkoLdLe72MEJtwKj0E3Z6hNuwlx9z07sTMDtD0qMURr9E0oniys9sj5ALhdSmw+tvXveitXxO4gMAp4sPtNRqlDM8rUoIeaD9Ur+PerMhVGmMJpfckPg5ztEUBTN+vMRuvS3OEkbHXmu0XUivSpqfPnW3LguYyLTX6iX7eG0y0I0/eyrMVXpZITG/Egv+N2ID6nPr25Is28boJ63Js/lvlTfKYGmhQqCiSqDn7VelaLiiDYFl6sL3ucHqyl8QIDQmfWiV76FeBJfwdQORWwjNCK0oEgj9CfBigZ72fNbE5QAqWdUnfrS1kEdaET7AlK0o7d0KeeZE8xE3yp/MPB5d9f38zzCO51x90oe1dusEYrbmDZfQz5nK0hGmRJBBWlhBgL1V9S/44VG/r4p2h7iASW7ms1dQLnjKHJefMRt84Kea83SOYHW2jIpbEizKNdB5vGvZlJYITA1mZmaFKs8uv9A2PPLOAg4xyCCwsVCEiF3H4Uy0yQHBJ66Yc4ni7abe8DswCUeyrx2u0wKQPLHjS1m++rqy2wmd9IjA0RGnSGMoB1A2E= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BY5PR10MB4196.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(4326008)(66946007)(7406005)(66476007)(7416002)(8936002)(6486002)(36756003)(31686004)(5660300002)(66556008)(8676002)(38350700002)(2616005)(31696002)(316002)(44832011)(508600001)(86362001)(53546011)(2906002)(6666004)(52116002)(26005)(6512007)(6506007)(38100700002)(83380400001)(186003)(14583001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UjFWaHQyR0Z1aUtIR09COVptRE41RlZ0b1pHMlFFUElzRG16d2k4R29Mb25Q?= =?utf-8?B?WEZVT0RqbDBjSS93bmZuZjhyNW5XR2QxMERSRFJ6bThOR3FtM0RUdTVBcElO?= =?utf-8?B?Slh0SFgxS251NDFDK0s0UWVJN0FHU2RTb3kvQUZtMERkY0I1STdUYXNQNUpV?= =?utf-8?B?VjBYN1dZS2ttVzV1MkhjQlI3SHZjajRIaGx3NkRacHdpNW1rMWpLMU1aZUpL?= =?utf-8?B?SlNaU1hWYTg3OVJnUHZJYWJoMklSMmtENHU4b1k3S0tuWEI1ZVJ1VzlQTmZW?= =?utf-8?B?UW9EUzRiazIvVGhmZDU5MEZWVkFnR1BsUnAyQkpmdlRQajYxelNVTkNaQWNx?= =?utf-8?B?V3NDNzZZSm90Si9UQnJhNXQvQ0ljMkJWdVZNZHVWQ3JNVDFkdWlJb2hobENB?= =?utf-8?B?OU51dGVwZCtNaGxRaXBSaHhIZjNYREFTcEhFQjZFSVpJd2Nqc1lFS3ppSlJ4?= =?utf-8?B?bDlJUjVQTkh0VWhUczB3VUJjNHhrOGpyMisxQUt1RmlkY0h6VXpPa3ltekhK?= =?utf-8?B?bSs1dWY2YzMvWldlTXU4djEwbjJmbzEvN21ZcXV6cEh0c1BBeFhvcXFkdHFJ?= =?utf-8?B?WllWMGJnOG9Sb0g0Rml5OHpXeW80QzErY28xaTl1czhBNlFScFdiVXJ0SnZZ?= =?utf-8?B?QzlsY0greHVBTktkMmgxN3NreG16cHlMSFhzWG1WeWtWQTA3OUFlbjJBOUhO?= =?utf-8?B?T2s4c0VPclhYTmNiOTNRYjd4K2FKYkE2OStHWWFjT0l6cENvQVkrdDVhUVJW?= =?utf-8?B?M3N5VWJ5UTQ4dkVrSXRudVVrbTRPVEU5YnJsOHg2NG8rT053VFhSOUYrZG5p?= =?utf-8?B?VEpsa0lXdmdZcHZRMmpaOXFpVXZnU3hZTjlIUVpuZnJGZXVaK1hKcFc0aGNW?= =?utf-8?B?YkJvSmJPdFFQdlVpYXliVmt5OU82VU5FdDZvNEg3TDNlSG5JVy83dVI4cUp3?= =?utf-8?B?eG16L1djdE15VFkxRmRyS1NEWFpJWlUzV09sSjR5RXF4MzY1MExtMmM0cTVv?= =?utf-8?B?aG12VGFpcDhBZ1hDbFNOVXhaVVYydEZENGh3TTFaeTFLcy9MaURIYkordVlH?= =?utf-8?B?TkRjbGhkN1I0WmNGSEFDcVkzczByZXBwSFpVczZ4dktDZjBTeXVTNnV5SzZI?= =?utf-8?B?MlpkOUVMR2lTdDJFY1pXU2pXSFFlY09CVHhUZTBacjd0Vy94Wi85bmFrWUQ4?= =?utf-8?B?RHJScWMwN3JkZU1QYmpGbmx4MW5pRi9kSUp6M0Z0UEFHVjV0djhSdSsyc0la?= =?utf-8?B?V3lqb0xocGRiVm5RZjQ1NlJ3SWNYWW5rNnlkdW44Ym9lUktOY3dXem1nVWNM?= =?utf-8?B?QWM3MUJKMFAwWjFSdDBUNFVWeWFtM080Z0FQeFAvVlQ2aUo0eUZUcEl3ZmRS?= =?utf-8?B?ZXVRZ0g5cWdvZlQvdTM1L1dHQUhJa0txVmxtRlRiUVdiRjArL0JDcFZMSndy?= =?utf-8?B?WlRyaGZKRjBncXpVU1lKNVBOQ0VKaXlINkdjSm5hclF3cGV6ckdLY285OSsy?= =?utf-8?B?S0tYTmMvRzVkazlBSDEyTG1CcGVnZFNUTldNQUFxYS9pSWNIVlVaYUlRMlVK?= =?utf-8?B?YjlkNEdsL1J5QUlEWC9kbElzWHZtU2NLZFVRV0NGZFd4TmlUeDloVlgrMWQ2?= =?utf-8?B?Vlk4dUkzTXpwaGVnNm9IRlZOK1E5VlFYQURCcVZGUFFENWVTVU50NFJsMTN5?= =?utf-8?B?ZlJlVlI1SnhHLzVaWk1vMWM1NmkyOTdRMFhmV0NJMmVKdzg2SVFXazFXRjVn?= =?utf-8?B?ZlNROEZPZDBQVnNTRTJmWktBV1BYcDRQQ0UxQ21WdjZYY25POVRKUFE3dEkw?= =?utf-8?B?SFplZXp5Tkc4bkNsYnMzbGxFYzJ5RzBodmhJS3VMOVA2bjFTRWtoaHBiS3VY?= =?utf-8?B?bkxnbjdIVThxMXFtR2hPWmM3dThFbzh3aUlHcEVra0N1cWFRS0dGdWlSampW?= =?utf-8?B?OWgrLzNXR0RGaUphU05xNjg2b3AyNVM3cjVJTmtCZTRkQnQ5Q2R1UENEamg4?= =?utf-8?B?OXZFV3BlN1NUVE02WTRSL2JEOXdGc3pDVm5walZGQ1hxZ0NTd3lxYWJ1Ykwy?= =?utf-8?B?TDRRVTFieklLUUN6aDZJeHlsYVhUdCtmTWFPaE8ra2xvZytMZFpvUENkUklT?= =?utf-8?B?cVFWaEhpSjZkR3c5RWt6TGFwSWxCOWlleGg5ai9Odk1FaHJWS2h0L1h1VFJi?= =?utf-8?B?d3BaTi90K0N1R0N6b1RhVU9Pc0wxaXhxR1ZzajdSS3Q0ZnliTGc2RTJOcVZK?= =?utf-8?B?Y25rQ0M1YkovaGhXbndVL1pzVzU3MkdYdUZIckhRWG15Z3FwbGRRZDMzcmlE?= =?utf-8?B?dFdhUm05dVdJbHA4K3dmcGVTNUlvTWpxdGVad0ZCQjYxRy9RQ2xueG1YOTA1?= =?utf-8?Q?Geb3EXW5F6OGdN+I=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4003ceb6-f24f-4649-eb93-08da2eed2576 X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2022 23:15:29.8898 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: K1bnGNhELQChSNfy5CTy/SaQnymw6hEqvFgFwFULzEtHn5gm5iVl+YxCPSoFsurQ6U5HEbbPL2ONKsKkMJNPWw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR10MB4874 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.858 definitions=2022-05-05_10:2022-05-05,2022-05-05 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 bulkscore=0 malwarescore=0 spamscore=0 mlxlogscore=999 mlxscore=0 suspectscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2205050147 X-Proofpoint-GUID: tdJxcKUgCIC238fa_Oi_7Rf9oSJGCkZP X-Proofpoint-ORIG-GUID: tdJxcKUgCIC238fa_Oi_7Rf9oSJGCkZP Precedence: bulk List-ID: X-Mailing-List: linux-arch@vger.kernel.org On 4/29/22 01:14, Baolin Wang wrote: > It is incorrect to use ptep_clear_flush() to nuke a hugetlb page > table when unmapping or migrating a hugetlb page, and will change > to use huge_ptep_clear_flush() instead in the following patches. > > So this is a preparation patch, which changes the huge_ptep_clear_flush() > to return the original pte to help to nuke a hugetlb page table. > > Signed-off-by: Baolin Wang > --- > arch/arm64/include/asm/hugetlb.h | 4 ++-- > arch/arm64/mm/hugetlbpage.c | 12 +++++------- > arch/ia64/include/asm/hugetlb.h | 4 ++-- > arch/mips/include/asm/hugetlb.h | 9 ++++++--- > arch/parisc/include/asm/hugetlb.h | 4 ++-- > arch/powerpc/include/asm/hugetlb.h | 9 ++++++--- > arch/s390/include/asm/hugetlb.h | 6 +++--- > arch/sh/include/asm/hugetlb.h | 4 ++-- > arch/sparc/include/asm/hugetlb.h | 4 ++-- > include/asm-generic/hugetlb.h | 4 ++-- > 10 files changed, 32 insertions(+), 28 deletions(-) The above changes look straight forward. Happy that you Cc'ed impacted arch maintainers so they can at least have a look. The only user of huge_ptep_clear_flush() today is hugetlb_cow/wp() in mm/hugetlb.c. Any reason why you did not change that code? At least cast the return of huge_ptep_clear_flush() to void with a comment? Not absolutely necessary. Acked-by: Mike Kravetz -- Mike Kravetz