From mboxrd@z Thu Jan 1 00:00:00 1970 From: "H. Peter Anvin" Subject: Re: + preadv-pwritev-add-preadv-and-pwritev-system-calls.patch added to -mm tree Date: Mon, 02 Feb 2009 13:50:09 -0800 Message-ID: <49876A91.4000705@zytor.com> References: <200902022135.n12LZa1a010673@imap1.linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <200902022135.n12LZa1a010673-AB4EexQrvXRQetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org> Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org Cc: mm-commits-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kraxel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, arnd-r2nGTMty4D4@public.gmane.org, linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arch-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, mingo-X9Un+BFzKDI@public.gmane.org, ralf-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org, tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org, viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org List-Id: linux-arch.vger.kernel.org akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org wrote: > > This prototype has one problem though: On 32bit archs is the (64bit) > offset argument unaligned, which the syscall ABI of several archs doesn't > allow to do. At least s390 needs a wrapper in glibc to handle this. As > we'll need a wrappers in glibc anyway I've decided to push problem to > glibc entriely and use a syscall prototype which works without > arch-specific wrappers inside the kernel: The offset argument is > explicitly splitted into two 32bit values. > That rather sucks. It'd be cleaner to just shuffle the argument order. -hpa -- To unsubscribe from this list: send the line "unsubscribe linux-api" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from terminus.zytor.com ([198.137.202.10]:60919 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754361AbZBBVwk (ORCPT ); Mon, 2 Feb 2009 16:52:40 -0500 Message-ID: <49876A91.4000705@zytor.com> Date: Mon, 02 Feb 2009 13:50:09 -0800 From: "H. Peter Anvin" MIME-Version: 1.0 Subject: Re: + preadv-pwritev-add-preadv-and-pwritev-system-calls.patch added to -mm tree References: <200902022135.n12LZa1a010673@imap1.linux-foundation.org> In-Reply-To: <200902022135.n12LZa1a010673@imap1.linux-foundation.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: akpm@linux-foundation.org Cc: mm-commits@vger.kernel.org, kraxel@redhat.com, arnd@arndb.de, linux-api@vger.kernel.org, linux-arch@vger.kernel.org, mingo@elte.hu, ralf@linux-mips.org, tglx@linutronix.de, viro@zeniv.linux.org.uk Message-ID: <20090202215009.5AYZmoF94yqzhgFBq8_ZpIc4D7SxJYL7QNCoFWEFkYc@z> akpm@linux-foundation.org wrote: > > This prototype has one problem though: On 32bit archs is the (64bit) > offset argument unaligned, which the syscall ABI of several archs doesn't > allow to do. At least s390 needs a wrapper in glibc to handle this. As > we'll need a wrappers in glibc anyway I've decided to push problem to > glibc entriely and use a syscall prototype which works without > arch-specific wrappers inside the kernel: The offset argument is > explicitly splitted into two 32bit values. > That rather sucks. It'd be cleaner to just shuffle the argument order. -hpa