Re: [PATCH 01/10] percpu: use dynamic percpu allocator as the default percpu allocator

[Tejun Heo <tj@kernel.org>]

James Bottomley wrote:
> On Wed, 2009-06-24 at 15:45 +0900, Tejun Heo wrote:
>> This patch makes most !CONFIG_HAVE_SETUP_PER_CPU_AREA archs use
>> dynamic percpu allocator.  The first chunk is allocated using
>> embedding helper and 8k is reserved for modules.  This ensures that
>> the new allocator behaves almost identically to the original allocator
>> as long as static percpu variables are concerned, so it shouldn't
>> introduce much breakage.
>>
>> s390 and alpha use custom SHIFT_PERCPU_PTR() to work around addressing
>> range limit the addressing model imposes.  Unfortunately, this breaks
>> if the address is specified using a variable, so for now, the two
>> archs aren't converted.
>>
>> The following architectures are affected by this change.
>>
>> * sh
>> * arm
>> * cris
>> * mips
>> * sparc(32)
>> * blackfin
>> * avr32
>> * parisc (broken, under investigation)
> 
> OK, I thought I'd investigate this.  Unfortunately, your git tree
> doesn't build when pulled into head ... could you update?
> 
> mm/percpu.c: In function 'setup_per_cpu_areas':
> mm/percpu.c:2007: error: too many arguments to function 'pcpu_embed_first_chunk'

Hmm... strange.  I don't see such failures.  Can you please try the
following git tree?

  git://git.kernel.org/pub/scm/linux/kernel/git/tj/percpu.git for-james

The contains all posted percpu patches and pulls in the current
linus#master (rc1).

Thanks.

-- 
tejun