From: Michal Marek <mmarek-AlSwsSmVLrQ@public.gmane.org>
To: Jan Beulich <JBeulich-Et1tbQHTxzrQT0dZR+AlfA@public.gmane.org>
Cc: Rusty Russell <rusty-8n+1lVoiYb80n/F98K4Iww@public.gmane.org>,
Ingo Molnar <mingo-X9Un+BFzKDI@public.gmane.org>,
tony.luck-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
Jon Masters <jonathan-Zp4isUonpHBD60Wz+7aTrA@public.gmane.org>,
Thomas Gleixner <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>,
linux-arch-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-modules-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org
Subject: Re: [PATCH] reduce export symbol CRC table size on 64-bit archs
Date: Mon, 13 Jul 2009 10:11:40 +0200 [thread overview]
Message-ID: <4A5AEC3C.2060608@suse.cz> (raw)
In-Reply-To: <4A57089B0200007800009C0E-Qfbpwmsw6RoS3W1tAdPHOtBPR1lH4CV8@public.gmane.org>
Jan Beulich napsal(a):
> Actually I meanwhile think that module-init-tools can easily detect the changed
> layout without any further kernel side adjustments: Since it is known that a
> CRC always is a 32-bit value, simply checking whether the so-far-used 64-bit
> value has more than 32 significant bits should suffice: If so, the new layout
> is being used (with the symbol name starting at offset 4), else the old one is
> in effect (name at offset 8). This ought to be a pretty trivial change to that
> code.
But old module-init-tools will continue reading garbage in this case.
Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-modules" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Michal Marek <mmarek@suse.cz>
To: Jan Beulich <JBeulich@novell.com>
Cc: Rusty Russell <rusty@rustcorp.com.au>,
Ingo Molnar <mingo@elte.hu>,
tony.luck@intel.com, Jon Masters <jonathan@jonmasters.org>,
Thomas Gleixner <tglx@linutronix.de>,
linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-modules@vger.kernel.org, hpa@zytor.com
Subject: Re: [PATCH] reduce export symbol CRC table size on 64-bit archs
Date: Mon, 13 Jul 2009 10:11:40 +0200 [thread overview]
Message-ID: <4A5AEC3C.2060608@suse.cz> (raw)
Message-ID: <20090713081140.UfECIcwI64uwtfdlrXM7Z6Pp-ifjouZullZ2sI9Cbnw@z> (raw)
In-Reply-To: <4A57089B0200007800009C0E@vpn.id2.novell.com>
Jan Beulich napsal(a):
> Actually I meanwhile think that module-init-tools can easily detect the changed
> layout without any further kernel side adjustments: Since it is known that a
> CRC always is a 32-bit value, simply checking whether the so-far-used 64-bit
> value has more than 32 significant bits should suffice: If so, the new layout
> is being used (with the symbol name starting at offset 4), else the old one is
> in effect (name at offset 8). This ought to be a pretty trivial change to that
> code.
But old module-init-tools will continue reading garbage in this case.
Michal
next prev parent reply other threads:[~2009-07-13 8:11 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-30 11:51 [PATCH] reduce export symbol CRC table size on 64-bit archs Jan Beulich
2009-06-30 11:51 ` Jan Beulich
2009-06-30 22:09 ` Ingo Molnar
2009-07-01 5:00 ` Rusty Russell
2009-07-01 5:00 ` Rusty Russell
2009-07-01 7:00 ` Jan Beulich
2009-07-01 7:00 ` Jan Beulich
[not found] ` <4A4A18780200007800008345-Qfbpwmsw6RoS3W1tAdPHOtBPR1lH4CV8@public.gmane.org>
2009-07-03 20:16 ` Michal Marek
2009-07-03 20:16 ` Michal Marek
2009-07-06 7:42 ` Jan Beulich
[not found] ` <4A51C71B0200007800008EE2-Qfbpwmsw6RoS3W1tAdPHOtBPR1lH4CV8@public.gmane.org>
2009-07-09 11:14 ` Rusty Russell
2009-07-09 11:14 ` Rusty Russell
2009-07-10 7:23 ` Jan Beulich
[not found] ` <4A57089B0200007800009C0E-Qfbpwmsw6RoS3W1tAdPHOtBPR1lH4CV8@public.gmane.org>
2009-07-10 14:36 ` H. Peter Anvin
2009-07-10 14:36 ` H. Peter Anvin
2009-07-10 15:50 ` Jon Masters
2009-07-10 15:50 ` Jon Masters
2009-07-13 8:11 ` Michal Marek [this message]
2009-07-13 8:11 ` Michal Marek
2009-07-13 8:44 ` Jan Beulich
[not found] ` <4A5B101E020000780000A284-Qfbpwmsw6RoS3W1tAdPHOtBPR1lH4CV8@public.gmane.org>
2009-07-14 10:29 ` Jon Masters
2009-07-14 10:29 ` Jon Masters
[not found] ` <1247567372.31188.229.camel-gHXTUq7nJ1kAgR79ElizB2+biTydnCM9ILAQCsJbaHk@public.gmane.org>
2009-07-14 10:44 ` Marco d'Itri
2009-07-14 10:44 ` Marco d'Itri
2009-07-14 16:43 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A5AEC3C.2060608@suse.cz \
--to=mmarek-alswssmvlrq@public.gmane.org \
--cc=JBeulich-Et1tbQHTxzrQT0dZR+AlfA@public.gmane.org \
--cc=hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org \
--cc=jonathan-Zp4isUonpHBD60Wz+7aTrA@public.gmane.org \
--cc=linux-arch-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-modules-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mingo-X9Un+BFzKDI@public.gmane.org \
--cc=rusty-8n+1lVoiYb80n/F98K4Iww@public.gmane.org \
--cc=tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org \
--cc=tony.luck-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox