From mboxrd@z Thu Jan 1 00:00:00 1970 From: "H. Peter Anvin" Subject: Re: [PATCH 3/6] generic sys_ipc wrapper Date: Mon, 01 Feb 2010 14:25:34 -0800 Message-ID: <4B6754DE.5070100@zytor.com> References: <20100201185544.GC11045@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from terminus.zytor.com ([198.137.202.10]:48107 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752418Ab0BAWhS (ORCPT ); Mon, 1 Feb 2010 17:37:18 -0500 In-Reply-To: <20100201185544.GC11045@lst.de> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Christoph Hellwig Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux@arm.linux.org.uk, starvik@axis.com, jesper.nilsson@axis.com, dhowells@redhat.com, ysato@users.sourceforge.jp, takata@linux-m32r.org, geert@linux-m68k.org, zippel@linux-m68k.org, gerg@uclinux.org, ralf@linux-mips.org, benh@kernel.crashing.org, schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com, lethal@linux-sh.org, davem@davemloft.net, jdike@addtoit.com, tglx@linutronix.de, mingo@redhat.com, viro@zeniv.linux.org.uk On 02/01/2010 10:55 AM, Christoph Hellwig wrote: > > Add a generic implementation of the ipc demultiplexer syscall. Except for > s390 and sparc64 all implementations of the sys_ipc are nearly identical. > > There are slight differences in the types of the parameters, where mips > and powerpc as the only 64-bit architectures with sys_ipc use unsigned long > for the "third" argument as it gets casted to a pointer later, while it > traditionally is an "int" like most other paramters. frv goes even further > and uses unsigned long for all parameters execept for "ptr" which is a pointer > type everywhere. The change from int to unsigned long for "third" and back > to "int" for the others on frv should be fine due to the in-register calling > conventions for syscalls (we already had a similar issue with the generic > sys_ptrace), but I'd prefer to have the arch maintainers looks over this > in details. > > Except for that h8300, m68k and m68knommu lack an impplementation of the > semtimedop sub call which this patch adds, and various architectures have > different strategies for the SHMAT version 1 case which apparently never > gets used - at least on i386 it seems superflous as the compat code on > x86-64 and ia64 doesn't even bother to implement it. > > Signed-off-by: Christoph Hellwig > Looks good from an x86 perspective. Reviewed-by: H. Peter Anvin