From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yinghai Subject: Re: [PATCH 03/35] lmb: Add ARCH_DISCARD_LMB to put lmb code to .init Date: Thu, 13 May 2010 23:21:40 -0700 Message-ID: <4BECEBF4.7000402@oracle.com> References: <1273796396-29649-1-git-send-email-yinghai@kernel.org> <1273796396-29649-4-git-send-email-yinghai@kernel.org> <1273803249.21352.357.camel@pasglop> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: Received: from rcsinet10.oracle.com ([148.87.113.121]:18186 "EHLO rcsinet10.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754832Ab0ENGYY (ORCPT ); Fri, 14 May 2010 02:24:24 -0400 In-Reply-To: <1273803249.21352.357.camel@pasglop> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Benjamin Herrenschmidt Cc: Ingo Molnar , Thomas Gleixner , "H. Peter Anvin" , Andrew Morton , David Miller , Linus Torvalds , Johannes Weiner , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org On 05/13/2010 07:14 PM, Benjamin Herrenschmidt wrote: > On Thu, 2010-05-13 at 17:19 -0700, Yinghai Lu wrote: >> So those lmb bits could be released after kernel is booted up. >> >> Arch code could define ARCH_DISCARD_LMB in asm/lmb.h, >> __init_lmb will become __init, __initdata_lmb will becom __initdata >> >> x86 code will use that. > > So you do not intend to use lmb after boot ? This will break the debugfs > files unless you also remove those. no, x86 don't lmb after boot. yes ... >> @@ -695,7 +695,7 @@ static int __init early_lmb(char *p) >> } >> early_param("lmb", early_lmb); >> >> -#ifdef CONFIG_DEBUG_FS >> +#if defined(CONFIG_DEBUG_FS) && !defined(ARCH_DISCARD_LMB) >> >> static int lmb_debug_show(struct seq_file *m, void *private) >> { > it will check ARCH_DISCARD_LMB