From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yinghai Subject: Re: [PATCH 07/37] lmb: Add lmb_find_area() Date: Sun, 16 May 2010 23:09:28 -0700 Message-ID: <4BF0DD98.1090904@oracle.com> References: <1273866363-14249-1-git-send-email-yinghai@kernel.org> <1273866363-14249-8-git-send-email-yinghai@kernel.org> <1273876749.21352.645.camel@pasglop> <4BEDD7D4.90002@oracle.com> <1274057329.21352.709.camel@pasglop> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: Received: from rcsinet10.oracle.com ([148.87.113.121]:63363 "EHLO rcsinet10.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753068Ab0EQGLC (ORCPT ); Mon, 17 May 2010 02:11:02 -0400 In-Reply-To: <1274057329.21352.709.camel@pasglop> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Benjamin Herrenschmidt Cc: Ingo Molnar , Thomas Gleixner , "H. Peter Anvin" , Andrew Morton , David Miller , Linus Torvalds , Johannes Weiner , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org On 05/16/2010 05:48 PM, Benjamin Herrenschmidt wrote: > On Fri, 2010-05-14 at 16:08 -0700, Yinghai wrote: >> how about >> lmb_reserve_area ==> lmb_reserve_range >> lmb_free_area ==> lmb_free_range > > I completely fail to see why you still need those two. They are exactly > the same thing as lmb_reserve() and lmb_free(), just with a slightly > different prototype. > >> or leave them that way, later replace them lmb_reserve and lmb_free >> one by one? > > Nah, if you have some use of the wrappers to ease the transition from > the existing x86 code, then just make up a couple of inline wrappers > somewhere inside the x86 code. You may not even want to call it > lmb_* at all... can you move asm/lmb.h down in linux/lmb.h ? so I can put the inline wrapper in arch/x86/include/asm/lmb.h. > > But here, I'll let Thomas and Peter decide what to do, it's really > x86 stuff at this stage. I don't want to see two subtlely different > APIs at the LMB level doing the same thing. > > Cheers, > Ben. > >