From: "H. Peter Anvin" <hpa@zytor.com>
To: Paul Mundt <lethal@linux-sh.org>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
Ingo Molnar <mingo@elte.hu>,
Luca Barbieri <luca@luca-barbieri.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Andrew Morton <akpm@linux-foundation.org>,
linux-arch@vger.kernel.org
Subject: Re: [GIT PULL] x86/atomic changes for v2.6.35
Date: Wed, 19 May 2010 12:00:41 -0700 [thread overview]
Message-ID: <4BF43559.6080808@zytor.com> (raw)
In-Reply-To: <20100519161828.GB16082@linux-sh.org>
On 05/19/2010 09:18 AM, Paul Mundt wrote:
>
> No, the problem isn't solved, you apparently overlooked the part of
> Geert's mail that point out that the test fails to build on architecures
> that _do_ have atomic64_t. All of arm/parisc/powerpc/sh select
> GENERIC_ATOMIC64, suggesting that the test itself was only ever tested on
> x86 and never on the generic implementation. While that may be par for
> the course these days, it's still pretty poor form.
>
I don't see any atomic64_t issues in the ARM, PowerPC or MIPS builds --
which doesn't mean they're not there, but if so they're obscured by
other errors. m68k is missing #include <asm-generic/atomic64.h> in
<asm/atomic.h>, and SPARC64 and S390 seems to have issues due to missing
<linux/kernel.h> in atomic64_test.c; the latter is indeed a bug in the
test and yes, should be fixed.
-hpa
prev parent reply other threads:[~2010-05-19 19:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20100517224531.GA27400@elte.hu>
2010-05-19 11:46 ` [GIT PULL] x86/atomic changes for v2.6.35 Geert Uytterhoeven
2010-05-19 14:24 ` H. Peter Anvin
2010-05-19 14:36 ` Stephen Rothwell
2010-05-19 15:01 ` H. Peter Anvin
2010-05-19 15:21 ` Stephen Rothwell
2010-05-19 16:18 ` Paul Mundt
2010-05-19 19:00 ` H. Peter Anvin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BF43559.6080808@zytor.com \
--to=hpa@zytor.com \
--cc=akpm@linux-foundation.org \
--cc=geert@linux-m68k.org \
--cc=lethal@linux-sh.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca@luca-barbieri.com \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).