From: Mark Lord <kernel@teksavvy.com>
To: Robert Hancock <hancockrwd@gmail.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Tejun Heo <tj@kernel.org>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
Colin Tuckley <colin.tuckley@arm.com>,
Jeff Garzik <jeff@garzik.org>,
linux-arch <linux-arch@vger.kernel.org>
Subject: Re: [PATCH v2] sata_sil24: Use memory barriers before issuing commands
Date: Wed, 23 Jun 2010 09:00:14 -0400 [thread overview]
Message-ID: <4C22055E.5060705@teksavvy.com> (raw)
In-Reply-To: <4C118697.9090305@gmail.com>
On 10/06/10 08:43 PM, Robert Hancock wrote:
..
> My memory is fuzzy but I thought this came up before on PPC and I also
> thought the conclusion was that the platform code (for writel, etc.)
> should enforce ordering of MMIO accesses with respect to normal RAM
> accesses. (Or maybe it was just MMIO accesses with respect to each
> other?) I don't think the answer to that question has been clearly
> documented anywhere, which is somewhat unfortunate.
..
Different problem. That discussion was for PIO reads into the page cache,
and ensuring coherency from all of that.
Whereas this patch is just ordinary low-level chipset programming,
and ensuring the descriptors are visible before issuing the "go" command.
prev parent reply other threads:[~2010-06-23 13:10 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20100610160212.18091.29856.stgit@e102109-lin.cambridge.arm.com>
[not found] ` <4C110EDD.2010409@kernel.org>
2010-06-10 16:23 ` [PATCH v2] sata_sil24: Use memory barriers before issuing commands Catalin Marinas
2010-06-10 16:42 ` Catalin Marinas
2010-06-11 0:43 ` Robert Hancock
2010-06-11 0:43 ` Robert Hancock
2010-06-11 1:38 ` Nick Piggin
2010-06-11 9:16 ` FUJITA Tomonori
2010-06-11 9:41 ` Catalin Marinas
2010-06-11 10:11 ` Nick Piggin
2010-06-11 10:11 ` Nick Piggin
2010-06-11 11:04 ` Catalin Marinas
2010-06-12 1:30 ` Robert Hancock
2010-06-15 11:10 ` Catalin Marinas
2010-06-15 11:10 ` Catalin Marinas
2010-06-15 11:31 ` Nick Piggin
2010-06-15 11:31 ` Nick Piggin
2010-06-19 22:32 ` Catalin Marinas
2010-06-19 22:32 ` Catalin Marinas
2010-06-14 0:35 ` FUJITA Tomonori
2010-06-23 13:00 ` Mark Lord [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C22055E.5060705@teksavvy.com \
--to=kernel@teksavvy.com \
--cc=catalin.marinas@arm.com \
--cc=colin.tuckley@arm.com \
--cc=hancockrwd@gmail.com \
--cc=jeff@garzik.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).