From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Metcalf Subject: Re: [PATCH] arch/tile: Add driver to enable access to the user dynamic network. Date: Fri, 2 Jul 2010 08:19:36 -0400 Message-ID: <4C2DD958.7030005@tilera.com> References: <201006252110.o5PLArvw010770@farm-0002.internal.tilera.com> <201006281312.16391.arnd@arndb.de> <4C28BE64.4050505@tilera.com> <201006282134.55166.arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-15" Content-Transfer-Encoding: 7bit Return-path: Received: from usmamail.tilera.com ([72.1.168.231]:23469 "EHLO USMAMAIL.TILERA.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757746Ab0GBMTj (ORCPT ); Fri, 2 Jul 2010 08:19:39 -0400 In-Reply-To: <201006282134.55166.arnd@arndb.de> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Arnd Bergmann Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org [The question is how to use from within .] On 6/28/2010 3:34 PM, Arnd Bergmann wrote: >> I think the only "true" fix would be to have a new >> > header that provides list_head (and presumably hlist_head and >> > hlist_node), which would include, as would our >> > . This is certainly in line with recent >> > header-separation changes (e.g. mm_types.h). Would there be interest in >> > a change like this? I implemented it in my tree, and if it sounds >> > plausible to you, I'll send out a git diff, but it looks pretty much >> > exactly like this description :-) >> > Yes, I think that would be a reasonable change. > > Another alternative might be to move the prefetch stuff from asm/processor.h > to asm/prefetch.h on all architectures, which also breaks the dependency loop, > unless I'm mistaken again In principle I like the idea, but I'm concerned that the #include of from will recursively include on some platforms; for example, s390 and xtensa include it directly. We (tile) were including it indirectly via , though this seems to be a spurious include on our part, but other platforms may also include it indirectly. To be fair, I'm not sure why is included from . It doesn't seem required for a tile build, at least, but no doubt it was put there for some reason. So, if there's a good reason for it to be there, I'd say that pushes us back toward a separate . Otherwise we can investigate splitting out the prefetch content on every platform to (presumably creating some empty headers on architectures that just use the gcc builtin) and adding new #includes of to files that reference the prefetch functionality. Arnd and other list folks, what's your instinct? -- Chris Metcalf, Tilera Corp. http://www.tilera.com