From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yinghai Lu Subject: Re: [patch 00/47] Sparse irq rework Date: Thu, 30 Sep 2010 22:54:29 -0700 Message-ID: <4CA57795.4040308@kernel.org> References: <20100930221351.682772535@linutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <20100930221351.682772535@linutronix.de> Sender: linux-kernel-owner@vger.kernel.org To: Thomas Gleixner Cc: LKML , linux-arch@vger.kernel.org, Linus Torvalds , Andrew Morton , x86@kernel.org, Peter Zijlstra , Benjamin Herrenschmidt , Paul Mundt , Russell King , David Woodhouse , Jesse Barnes , Grant Likely , "Eric W. Biederman" List-Id: linux-arch.vger.kernel.org On 09/30/2010 04:14 PM, Thomas Gleixner wrote: > The following patch series cleans up and mostly reimplements the core > sparse irq implementation and sanitizes the most complex (ab)user: > arch/x86 >=20 > The series is based on the previous rework of irq chip functions whic= h > is available at: >=20 > git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip.git= irq/core >=20 > A combined throwaway git repository with all the following patches on= top of > tip/irq/core is available at: >=20 > git://git.kernel.org/pub/scm/linux/kernel/git/tglx/linux-2.6-sparse= -irq.git >=20 > The overall changes are (full changelog below): > 56 files changed, 1229 insertions(+), 1682 deletions(-) >=20 > The series consists of 3 parts: >=20 > - cleanup of kernel/irq code and implementation of new allocator > - conversion of x86 to new irq_chip functions and new allocator > - trivial cleanup of the remaining users and removal of the old s= tuff >=20 > It's fully bisectable and survived a night of testing in my testfarm. CC kernel/irq/irqdesc.o kernel/irq/irqdesc.c:123: error: expected =91=3D=92, =91,=92, =91;=92, = =91asm=92 or =91__attribute__=92 before =91static=92 kernel/irq/irqdesc.c: In function =91alloc_descs=92: kernel/irq/irqdesc.c:176: error: implicit declaration of function =91al= loc_desc=92 kernel/irq/irqdesc.c:176: warning: assignment makes pointer from intege= r without a cast kernel/irq/irqdesc.c: In function =91early_irq_init=92: kernel/irq/irqdesc.c:207: warning: assignment makes pointer from intege= r without a cast kernel/irq/irqdesc.c: In function =91irq_get_next_irq=92: kernel/irq/irqdesc.c:346: error: implicit declaration of function =91fi= nd_next_bit_set=92 kernel/irq/irqdesc.c:347: error: implicit declaration of function =91ra= w_spin_unlock_irqsave=92 kernel/irq/irqdesc.c: In function =91kstat_irqs_cpu=92: kernel/irq/irqdesc.c:369: error: expected =91=3D=92, =91,=92, =91;=92, = =91asm=92 or =91__attribute__=92 before =91{=92 token kernel/irq/irqdesc.c:374: error: expected =91=3D=92, =91,=92, =91;=92, = =91asm=92 or =91__attribute__=92 before =91{=92 token kernel/irq/irqdesc.c:377: error: expected =91{=92 at end of input make[1]: *** [kernel/irq/irqdesc.o] Error 1 Yinghai From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from rcsinet10.oracle.com ([148.87.113.121]:31034 "EHLO rcsinet10.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752695Ab0JAFzt (ORCPT ); Fri, 1 Oct 2010 01:55:49 -0400 Message-ID: <4CA57795.4040308@kernel.org> Date: Thu, 30 Sep 2010 22:54:29 -0700 From: Yinghai Lu MIME-Version: 1.0 Subject: Re: [patch 00/47] Sparse irq rework References: <20100930221351.682772535@linutronix.de> In-Reply-To: <20100930221351.682772535@linutronix.de> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: Thomas Gleixner Cc: LKML , linux-arch@vger.kernel.org, Linus Torvalds , Andrew Morton , x86@kernel.org, Peter Zijlstra , Benjamin Herrenschmidt , Paul Mundt , Russell King , David Woodhouse , Jesse Barnes , Grant Likely , "Eric W. Biederman" Message-ID: <20101001055429.3WuCxkTVb_0j5BcigujnoDFBw3Ea7s7kS0anm74-9bU@z> On 09/30/2010 04:14 PM, Thomas Gleixner wrote: > The following patch series cleans up and mostly reimplements the core > sparse irq implementation and sanitizes the most complex (ab)user: > arch/x86 > > The series is based on the previous rework of irq chip functions which > is available at: > > git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip.git irq/core > > A combined throwaway git repository with all the following patches on top of > tip/irq/core is available at: > > git://git.kernel.org/pub/scm/linux/kernel/git/tglx/linux-2.6-sparse-irq.git > > The overall changes are (full changelog below): > 56 files changed, 1229 insertions(+), 1682 deletions(-) > > The series consists of 3 parts: > > - cleanup of kernel/irq code and implementation of new allocator > - conversion of x86 to new irq_chip functions and new allocator > - trivial cleanup of the remaining users and removal of the old stuff > > It's fully bisectable and survived a night of testing in my testfarm. CC kernel/irq/irqdesc.o kernel/irq/irqdesc.c:123: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘static’ kernel/irq/irqdesc.c: In function ‘alloc_descs’: kernel/irq/irqdesc.c:176: error: implicit declaration of function ‘alloc_desc’ kernel/irq/irqdesc.c:176: warning: assignment makes pointer from integer without a cast kernel/irq/irqdesc.c: In function ‘early_irq_init’: kernel/irq/irqdesc.c:207: warning: assignment makes pointer from integer without a cast kernel/irq/irqdesc.c: In function ‘irq_get_next_irq’: kernel/irq/irqdesc.c:346: error: implicit declaration of function ‘find_next_bit_set’ kernel/irq/irqdesc.c:347: error: implicit declaration of function ‘raw_spin_unlock_irqsave’ kernel/irq/irqdesc.c: In function ‘kstat_irqs_cpu’: kernel/irq/irqdesc.c:369: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘{’ token kernel/irq/irqdesc.c:374: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘{’ token kernel/irq/irqdesc.c:377: error: expected ‘{’ at end of input make[1]: *** [kernel/irq/irqdesc.o] Error 1 Yinghai