From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yinghai Lu Subject: Re: [patch 00/47] Sparse irq rework Date: Sat, 09 Oct 2010 19:32:52 -0700 Message-ID: <4CB125D4.9010003@kernel.org> References: <20100930221351.682772535@linutronix.de> <20101003112312.GB9844@angua.secretlab.ca> <20101003112920.GB32736@n2100.arm.linux.org.uk> <4CACFC23.4080504@kernel.org> <4CAD082B.40908@kernel.org> <4CAD1154.3080403@kernel.org> <4CAD4EC3.5060809@kernel.org> <4CAFEEFA.1070000@kernel.org> <4CB013CB.10 40904@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Thomas Gleixner Cc: Grant Likely , Russell King - ARM Linux , LKML , linux-arch@vger.kernel.org, Linus Torvalds , Andrew Morton , x86@kernel.org, Peter Zijlstra , Benjamin Herrenschmidt , Paul Mundt , David Woodhouse , Jesse Barnes , "Eric W. Biederman" List-Id: linux-arch.vger.kernel.org On 10/09/2010 05:12 AM, Thomas Gleixner wrote: > On Sat, 9 Oct 2010, Yinghai Lu wrote: >> On 10/08/2010 11:10 PM, Thomas Gleixner wrote: >>>> [ 59.449366] IP: [] acpi_pci_irq_find_prt_entry+0x85/0xb1 >>> >>> I can hardly see how this is related to the irq work. >>> >>>> [ 71.076886] Pid: 1, comm: swapper Tainted: G W 2.6.36-rc7-tip-yh-01944-ge8a4c5f-dirty #171 /Sun Fire x4800 >>>> [ 71.096947] RIP: 0010:[] [] strcmp+0x4/0x21 >>> >>> Ditto. >> >> don't know. >> >> but without merging your branch, those problems don't come out. >> >> only thing i can think about that you real free irq code could >> stress or expose other subsystem's bug etc. > > The first crash is in early boot and that code just fiddles with acpi > internal stuff. > > Is that fully reproducible ? If yes, any chance you can bisect it ? > not sure if it is right... the offending commit looks right. 2d80f45874f511aa31c34ab90cbcc5ebc2d62b1d is the first bad commit commit 2d80f45874f511aa31c34ab90cbcc5ebc2d62b1d Author: Thomas Gleixner Date: Mon Sep 27 20:55:03 2010 +0200 genirq: Query arch for number of early descriptors sparse irq sets up NR_IRQS_LEGACY irq descriptors and archs then go ahead and allocate more. Use the unused return value of arch_probe_nr_irqs() to let the architecture return the number of early allocations. Fix up all users. Signed-off-by: Thomas Gleixner Reviewed-by: Ingo Molnar :040000 040000 36e0def4d755eb235d8fce59ad821c6c6e8e1ca7 e74c903f10df76af20433a3fc6500b4e25de32d5 M arch :040000 040000 9015ff96c3853c81e3848e0921ccde3f56b8d452 c37e782686d0c3c99b42c15258ad07cace9eb415 M include :040000 040000 9ea7cd1eda18286f55b47941ad9ebd810a341b9a c1a57bc71c6769851659913d7b3f1d46577b90b3 M kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from rcsinet10.oracle.com ([148.87.113.121]:16739 "EHLO rcsinet10.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756140Ab0JJCeL (ORCPT ); Sat, 9 Oct 2010 22:34:11 -0400 Message-ID: <4CB125D4.9010003@kernel.org> Date: Sat, 09 Oct 2010 19:32:52 -0700 From: Yinghai Lu MIME-Version: 1.0 Subject: Re: [patch 00/47] Sparse irq rework References: <20100930221351.682772535@linutronix.de> <20101003112312.GB9844@angua.secretlab.ca> <20101003112920.GB32736@n2100.arm.linux.org.uk> <4CACFC23.4080504@kernel.org> <4CAD082B.40908@kernel.org> <4CAD1154.3080403@kernel.org> <4CAD4EC3.5060809@kernel.org> <4CAFEEFA.1070000@kernel.org> <4CB013CB.1040904@kernel.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: Thomas Gleixner Cc: Grant Likely , Russell King - ARM Linux , LKML , linux-arch@vger.kernel.org, Linus Torvalds , Andrew Morton , x86@kernel.org, Peter Zijlstra , Benjamin Herrenschmidt , Paul Mundt , David Woodhouse , Jesse Barnes , "Eric W. Biederman" Message-ID: <20101010023252.uVw3Nz7VYZGGD3jv9q_DmEOK3SEISyaZI0_dD2XVgos@z> On 10/09/2010 05:12 AM, Thomas Gleixner wrote: > On Sat, 9 Oct 2010, Yinghai Lu wrote: >> On 10/08/2010 11:10 PM, Thomas Gleixner wrote: >>>> [ 59.449366] IP: [] acpi_pci_irq_find_prt_entry+0x85/0xb1 >>> >>> I can hardly see how this is related to the irq work. >>> >>>> [ 71.076886] Pid: 1, comm: swapper Tainted: G W 2.6.36-rc7-tip-yh-01944-ge8a4c5f-dirty #171 /Sun Fire x4800 >>>> [ 71.096947] RIP: 0010:[] [] strcmp+0x4/0x21 >>> >>> Ditto. >> >> don't know. >> >> but without merging your branch, those problems don't come out. >> >> only thing i can think about that you real free irq code could >> stress or expose other subsystem's bug etc. > > The first crash is in early boot and that code just fiddles with acpi > internal stuff. > > Is that fully reproducible ? If yes, any chance you can bisect it ? > not sure if it is right... the offending commit looks right. 2d80f45874f511aa31c34ab90cbcc5ebc2d62b1d is the first bad commit commit 2d80f45874f511aa31c34ab90cbcc5ebc2d62b1d Author: Thomas Gleixner Date: Mon Sep 27 20:55:03 2010 +0200 genirq: Query arch for number of early descriptors sparse irq sets up NR_IRQS_LEGACY irq descriptors and archs then go ahead and allocate more. Use the unused return value of arch_probe_nr_irqs() to let the architecture return the number of early allocations. Fix up all users. Signed-off-by: Thomas Gleixner Reviewed-by: Ingo Molnar :040000 040000 36e0def4d755eb235d8fce59ad821c6c6e8e1ca7 e74c903f10df76af20433a3fc6500b4e25de32d5 M arch :040000 040000 9015ff96c3853c81e3848e0921ccde3f56b8d452 c37e782686d0c3c99b42c15258ad07cace9eb415 M include :040000 040000 9ea7cd1eda18286f55b47941ad9ebd810a341b9a c1a57bc71c6769851659913d7b3f1d46577b90b3 M kernel