From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Beulich" Subject: Re: [PATCH] Partially revert patch that encloses asm-offset.h numbers in brackets Date: Mon, 25 Oct 2010 16:05:23 +0100 Message-ID: <4CC5B8D3020000780001EFB4@vpn.id2.novell.com> References: <4CC5B1A1020000780001EF7C@vpn.id2.novell.com> <20101025140218.5092.74117.stgit@warthog.procyon.org.uk> <28707.1288018465@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8BIT Return-path: In-Reply-To: <28707.1288018465@redhat.com> Content-Disposition: inline Sender: linux-arch-owner@vger.kernel.org List-ID: To: Alexander van Heukelum Cc: Ingo Molnar , akpm@linux-foundation.org, "H. Peter Anvin" , torvalds@osdl.org, David Howells , linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org >>> On 25.10.10 at 16:54, David Howells wrote: > Jan Beulich wrote: > >> Isn't this a gas bug then? Anywhere you use a plain number you >> should also be permitted to use an expression. > > Whoever defined the gas assembly syntax for binutils specified that (N) as > an > operand defines an absolute address and N defines an immediate value. > > However, prefixing an expression with a unary plus works for me, so adding > this into my patch: > > - s:^->\([^ ]*\) [\$$#]*\([-0-9]*\) \(.*\):#define \1 \2 /* \3 */:; \ > + s:^->\([^ ]*\) [\$$#]*\([-0-9]*\) \(.*\):#define \1 +(\2) /* \3 */:; \ > > Does that work for you? Alexander, you seem to be having access to a worst case system - could you give this a try? Thanks, Jan