From: Tejun Heo <tj@kernel.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Guan Xuetao <guanxuetao@mprc.pku.edu.cn>,
Arnd Bergmann <arnd@arndb.de>,
linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv1 000/211] unicore32 architecture support
Date: Thu, 09 Dec 2010 15:05:06 +0100 [thread overview]
Message-ID: <4D00E212.9080001@kernel.org> (raw)
In-Reply-To: <alpine.LFD.2.00.1012091443580.2653@localhost6.localdomain6>
On 12/09/2010 02:49 PM, Thomas Gleixner wrote:
>> * Patches should be split according to logical steps of changes, not
>> per-file.
>>
>> * Patches should be bisectable. IOW, after applying upto any patch in
>> the series, the tree should be buildable and working.
>
> That does not work for a new architecture. There is nothing to bisect.
Sure, but at least it shouldn't introduce build scripts first which
wouldn't work at all.
>> * When posting a patch series, especially one as large as 211, please
>> make the mails for the actual patches replies to the head message.
>> Don't post it as 212 separate messages or replies to the immediate
>> previous patch.
>>
>> So, in short, if you're adding a whole new arch, just post it as a
>> single patch or a series of several patches if it requires changes
>> outside of the specific arch subtree.
>
> Crap. a single patch is a major PITA for review. It's even worse than
> 211 per file patches.
Cut the crap. A single patch may not be perfect for reviewing but
archs are often merged as a single giant patch as bisection is
meaningless anyway.
--
tejun
next prev parent reply other threads:[~2010-12-09 14:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-09 9:28 [PATCHv1 000/211] unicore32 architecture support Guan Xuetao
2010-12-09 9:50 ` Tejun Heo
2010-12-09 13:49 ` Thomas Gleixner
2010-12-09 14:05 ` Tejun Heo [this message]
2010-12-09 14:18 ` Thomas Gleixner
2010-12-09 14:27 ` Tejun Heo
2010-12-10 8:56 ` Guan Xuetao
2010-12-10 11:01 ` Thomas Gleixner
2010-12-10 12:35 ` Arnd Bergmann
2010-12-10 12:16 ` Arnd Bergmann
2010-12-09 17:50 ` James Bottomley
[not found] ` <028701cb9919$df3b7900$9db26b00$@mprc.pku.edu.cn>
[not found] ` <1292078266.4722.2.camel@mulgrave.site>
2010-12-13 6:58 ` Guan Xuetao
2010-12-13 9:51 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D00E212.9080001@kernel.org \
--to=tj@kernel.org \
--cc=arnd@arndb.de \
--cc=guanxuetao@mprc.pku.edu.cn \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).