From mboxrd@z Thu Jan 1 00:00:00 1970 From: "H. Peter Anvin" Subject: Re: [PATCH v4 09/24] bitops: introduce little-endian bitops for most architectures Date: Sun, 16 Jan 2011 13:18:07 -0800 Message-ID: <4D33608F.6060908@zytor.com> References: <1295183333-13802-1-git-send-email-akinobu.mita@gmail.com> <1295183333-13802-10-git-send-email-akinobu.mita@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from terminus.zytor.com ([198.137.202.10]:45729 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753752Ab1APVVz (ORCPT ); Sun, 16 Jan 2011 16:21:55 -0500 In-Reply-To: <1295183333-13802-10-git-send-email-akinobu.mita@gmail.com> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Akinobu Mita Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, akpm@linux-foundation.org, Richard Henderson , Ivan Kokshaysky , Hans-Christian Egtvedt , Bryan Wu , Mikael Starvik , David Howells , Yoshinori Sato , "Luck, Tony" , Ralf Baechle , Kyle McMartin , Matthew Wilcox , Grant Grundler , Paul Mundt , Kazumoto Kojima , "David S. Miller" , Chris Zankel , Ingo Molnar , Thomas Gleixner On 01/16/2011 05:08 AM, Akinobu Mita wrote: > Introduce little-endian bit operations to the architectures which do not > have native little-endian bit operations. (alpha, avr32, blackfin, cris, > frv, h8300, ia64, m32r, mips, mn10300, parisc, sh, sparc, tile, x86, > xtensa) > > These architectures can just include generic implementation > (asm-generic/bitops/le.h). > ACK on the patch, but the description is confusing for actual littleendian architectures -- the native bit operations on x86, for example, are in fact littleendian (and as such just wraps the existing native bitops.) -hpa