From: Cong Wang <amwang@redhat.com>
To: Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
linux-arch@vger.kernel.org
Subject: Re: smp: move smp setup functions to kernel/smp.c
Date: Wed, 23 Mar 2011 15:30:37 +0800 [thread overview]
Message-ID: <4D89A19D.3070002@redhat.com> (raw)
In-Reply-To: <20110323072457.GA4156@osiris.boeblingen.de.ibm.com>
于 2011年03月23日 15:24, Heiko Carstens 写道:
> This causes a build error on s390. The patch below will fix it.
> Cc'ed linux-arch just in case other architectures are affected as well.
>
> Subject: [PATCH] smp: add missing init.h include
>
> From: Heiko Carstens<heiko.carstens@de.ibm.com>
>
> 34db18a05 "smp: move smp setup functions to kernel/smp.c" causes this build
> error on s390 because of a missing init.h include:
>
> CC arch/s390/kernel/asm-offsets.s
> In file included from /home2/heicarst/linux-2.6/arch/s390/include/asm/spinlock.h:14:0,
> from include/linux/spinlock.h:87,
> from include/linux/seqlock.h:29,
> from include/linux/time.h:8,
> from include/linux/timex.h:56,
> from include/linux/sched.h:57,
> from arch/s390/kernel/asm-offsets.c:10:
> include/linux/smp.h:117:20: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'setup_nr_cpu_ids'
> include/linux/smp.h:118:20: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'smp_init'
>
> Fix it by adding the include statement.
>
> Signed-off-by: Heiko Carstens<heiko.carstens@de.ibm.com>
Ah... thanks for the fix!
Acked-by: WANG Cong <amwang@redhat.com>
prev parent reply other threads:[~2011-03-23 7:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201103230200.p2N20TTN010372@hera.kernel.org>
2011-03-23 7:24 ` smp: move smp setup functions to kernel/smp.c Heiko Carstens
2011-03-23 7:30 ` Cong Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D89A19D.3070002@redhat.com \
--to=amwang@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-arch@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).