From: David Daney <ddaney@caviumnetworks.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: David Daney <ddaney.cavm@gmail.com>,
David Rientjes <rientjes@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
"linux-mips@linux-mips.org" <linux-mips@linux-mips.org>,
"ralf@linux-mips.org" <ralf@linux-mips.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
David Daney <david.daney@cavium.com>,
"linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>,
Robin Holt <holt@sgi.com>
Subject: Re: [patch] hugetlb: remove dummy definitions of HPAGE_MASK and HPAGE_SIZE
Date: Mon, 21 Nov 2011 15:23:47 -0800 [thread overview]
Message-ID: <4ECADD83.3090108@caviumnetworks.com> (raw)
In-Reply-To: <CA+55aFwZxqHfEOemj+OJNKCj2toqGf3rkK-9iuS39L7iZsoH1Q@mail.gmail.com>
On 11/21/2011 02:43 PM, Linus Torvalds wrote:
> On Mon, Nov 21, 2011 at 2:23 PM, David Daney<ddaney.cavm@gmail.com> wrote:
>>
>> This whole comment strikes me as somewhat dishonest, as at the time David
>> Rientjes wrote it, he knew that there were dependencies on these symbols in
>> the linux-next tree.
>>
>> Now we can add these:
>> +#define HPAGE_SHIFT ({ BUG(); 0; })
>> +#define HPAGE_SIZE ({ BUG(); 0; })
>> +#define HPAGE_MASK ({ BUG(); 0; })
>
> Hell no.
>
> We don't do run-time BUG() things. No way, no how.
>
> If that #define cannot be used, then it damn well shouldn't be defined at all.
>
> David's patch is clearly the right thing to do. Don't try to send me
> the above kind of insane crap.
>
Ok Linus, for you I would recommend against running this git command on
your tree:
git grep -E '#define.+BUG\(\);'
It's not like there isn't precedence.
David Daney
next prev parent reply other threads:[~2011-11-21 23:23 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1321567050-13197-1-git-send-email-ddaney.cavm@gmail.com>
[not found] ` <alpine.DEB.2.00.1111171520130.20133@chino.kir.corp.google.com>
2011-11-17 23:22 ` [patch] hugetlb: remove dummy definitions of HPAGE_MASK and HPAGE_SIZE David Rientjes
2011-11-17 23:35 ` Andrew Morton
2011-11-17 23:44 ` David Rientjes
2011-11-17 23:52 ` David Daney
2011-11-17 23:57 ` Andrew Morton
2011-11-17 23:57 ` Andrew Morton
2011-11-17 23:57 ` David Rientjes
2011-11-17 23:57 ` David Rientjes
2011-11-21 22:23 ` David Daney
2011-11-21 22:43 ` Linus Torvalds
2011-11-21 23:23 ` David Daney [this message]
2011-11-21 23:43 ` Linus Torvalds
2011-11-21 23:50 ` Andrew Morton
2011-11-22 20:41 ` Andi Kleen
2011-11-21 23:47 ` David Daney
2011-11-21 23:53 ` Andrew Morton
2011-11-22 0:37 ` Linus Torvalds
2011-11-22 0:48 ` David Daney
2011-11-22 0:55 ` Linus Torvalds
2011-11-21 22:48 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ECADD83.3090108@caviumnetworks.com \
--to=ddaney@caviumnetworks.com \
--cc=akpm@linux-foundation.org \
--cc=david.daney@cavium.com \
--cc=ddaney.cavm@gmail.com \
--cc=holt@sgi.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=rientjes@google.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).