From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Daney Subject: Re: [patch] hugetlb: remove dummy definitions of HPAGE_MASK and HPAGE_SIZE Date: Mon, 21 Nov 2011 15:23:47 -0800 Message-ID: <4ECADD83.3090108@caviumnetworks.com> References: <1321567050-13197-1-git-send-email-ddaney.cavm@gmail.com> <4ECACF68.3020701@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail3.caviumnetworks.com ([12.108.191.235]:12702 "EHLO mail3.caviumnetworks.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754020Ab1KUXXs (ORCPT ); Mon, 21 Nov 2011 18:23:48 -0500 In-Reply-To: Sender: linux-arch-owner@vger.kernel.org List-ID: To: Linus Torvalds Cc: David Daney , David Rientjes , Andrew Morton , "linux-mips@linux-mips.org" , "ralf@linux-mips.org" , "linux-kernel@vger.kernel.org" , David Daney , "linux-arch@vger.kernel.org" , Robin Holt On 11/21/2011 02:43 PM, Linus Torvalds wrote: > On Mon, Nov 21, 2011 at 2:23 PM, David Daney wrote: >> >> This whole comment strikes me as somewhat dishonest, as at the time David >> Rientjes wrote it, he knew that there were dependencies on these symbols in >> the linux-next tree. >> >> Now we can add these: >> +#define HPAGE_SHIFT ({ BUG(); 0; }) >> +#define HPAGE_SIZE ({ BUG(); 0; }) >> +#define HPAGE_MASK ({ BUG(); 0; }) > > Hell no. > > We don't do run-time BUG() things. No way, no how. > > If that #define cannot be used, then it damn well shouldn't be defined at all. > > David's patch is clearly the right thing to do. Don't try to send me > the above kind of insane crap. > Ok Linus, for you I would recommend against running this git command on your tree: git grep -E '#define.+BUG\(\);' It's not like there isn't precedence. David Daney