From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Metcalf Subject: Re: [PATCH] lib/devres.c: allow specifying NO_IOPORT while using PCI Date: Mon, 5 Dec 2011 15:08:42 -0500 Message-ID: <4EDD24CA.2020906@tilera.com> References: <1616727.0BYPKXtoA0@wuerfel> <4ED91D95.6040601@tilera.com> <201112051514.02360.arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <201112051514.02360.arnd@arndb.de> Sender: linux-pci-owner@vger.kernel.org To: Arnd Bergmann Cc: linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-arch@vger.kernel.org, Rolf Eike Beer , Andrew Morton , "Maxin B. John" , Tejun Heo , "Michael S. Tsirkin" , Lucas De Marchi , Paul Mundt , Jesse Barnes , "David S. Miller" , Al Viro List-Id: linux-arch.vger.kernel.org On 12/5/2011 10:14 AM, Arnd Bergmann wrote: > On Friday 02 December 2011, Chris Metcalf wrote: >> The specific issue I saw was calls to pcim_iomap_{regions,table} from >> drivers/ata/libata-sff.c and drivers/ata/sata_sil24.c; we use the >> sata_sil24 in one of our platforms (TILEmpower). > Hmm, so sata_sil24 does not actually use PIO, so we can probably find a > way to make that work. OK, that would be good. I'm not familiar enough with the driver (or indeed the devres stuff) to really take an effective swing at this myself, though. > Why do you have to build libata-sff? Shouldn't > that only be needed if you actually have an sff-type controller? Yes, I think this is an accidental legacy of the original development work for PCI root complex three years ago. I disabled ATA_SFF and booted up a number of our inhouse platforms, and all the devices appear to work fine without it. I've now turned it off in our standard configuration. -- Chris Metcalf, Tilera Corp. http://www.tilera.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from usmamail.tilera.com ([206.83.70.75]:32490 "EHLO USMAMAIL.TILERA.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756163Ab1LEUIo (ORCPT ); Mon, 5 Dec 2011 15:08:44 -0500 Message-ID: <4EDD24CA.2020906@tilera.com> Date: Mon, 5 Dec 2011 15:08:42 -0500 From: Chris Metcalf MIME-Version: 1.0 Subject: Re: [PATCH] lib/devres.c: allow specifying NO_IOPORT while using PCI References: <1616727.0BYPKXtoA0@wuerfel> <4ED91D95.6040601@tilera.com> <201112051514.02360.arnd@arndb.de> In-Reply-To: <201112051514.02360.arnd@arndb.de> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: Arnd Bergmann Cc: linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-arch@vger.kernel.org, Rolf Eike Beer , Andrew Morton , "Maxin B. John" , Tejun Heo , "Michael S. Tsirkin" , Lucas De Marchi , Paul Mundt , Jesse Barnes , "David S. Miller" , Al Viro Message-ID: <20111205200842.ccyUmyRbAlHXpcpmG1TwJfmZELCLfgMux-IIvWLZ7Bw@z> On 12/5/2011 10:14 AM, Arnd Bergmann wrote: > On Friday 02 December 2011, Chris Metcalf wrote: >> The specific issue I saw was calls to pcim_iomap_{regions,table} from >> drivers/ata/libata-sff.c and drivers/ata/sata_sil24.c; we use the >> sata_sil24 in one of our platforms (TILEmpower). > Hmm, so sata_sil24 does not actually use PIO, so we can probably find a > way to make that work. OK, that would be good. I'm not familiar enough with the driver (or indeed the devres stuff) to really take an effective swing at this myself, though. > Why do you have to build libata-sff? Shouldn't > that only be needed if you actually have an sff-type controller? Yes, I think this is an accidental legacy of the original development work for PCI root complex three years ago. I disabled ATA_SFF and booted up a number of our inhouse platforms, and all the devices appear to work fine without it. I've now turned it off in our standard configuration. -- Chris Metcalf, Tilera Corp. http://www.tilera.com