From: Michael Cree <mcree@orcon.net.nz>
To: Tony Luck <tony.luck@intel.com>
Cc: linux-arch@vger.kernel.org
Subject: Re: why doesn't x86_32 have the accept4() syscall?
Date: Thu, 12 Jan 2012 13:33:37 +1300 [thread overview]
Message-ID: <4F0E2A61.1090609@orcon.net.nz> (raw)
In-Reply-To: <CA+8MBbLe5uC4gMg9vySTWYUsNv=P-9spnNbKsFAZqQCT_Wk+YQ@mail.gmail.com>
On 10/01/12 10:26, Tony Luck wrote:
> I've been using the warnings from scripts/checksyscalls.sh to let me know
> when some new system calls are added, so I can add them to ia64. But
> it was recently brought to my attention that I didn't have accept4(). I missed
> it because I didn't see a warning, which was because this script just compares
> against the 32-bit x86 list.
>
> A casual grep shows that:
> alpha, arm, microblaze, mips, parisc, powerpc, sh and sparc
> managed to add accept4 without getting the "warning syscall
> .... not implemented"
A search of the git log would reveal that on Alpha we only very recently
added accept4 because we had also missed it! We were badly bit by the
latest udev needing accept4.
The question that I think would be more pertinent is: How do we know
that we have implemented all relevant syscalls when the checksyscalls.sh
script is not a sufficient check?
Cheers
Michael.
prev parent reply other threads:[~2012-01-12 0:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-09 21:26 why doesn't x86_32 have the accept4() syscall? Tony Luck
2012-01-09 21:36 ` David Miller
2012-01-10 16:03 ` Jamie Lokier
2012-01-10 17:00 ` Geert Uytterhoeven
2012-01-10 20:07 ` David Miller
2012-01-12 0:33 ` Michael Cree [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F0E2A61.1090609@orcon.net.nz \
--to=mcree@orcon.net.nz \
--cc=linux-arch@vger.kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).