From mboxrd@z Thu Jan 1 00:00:00 1970 From: "H. Peter Anvin" Subject: Re: [PATCH 21/21] posix_types: Remove fd_set macros Date: Tue, 14 Feb 2012 12:14:44 -0800 Message-ID: <4F3AC0B4.1020203@intel.com> References: <4F32A98F.7030400@zytor.com> <1328677745-20121-22-git-send-email-hpa@zytor.com> <1328677745-20121-1-git-send-email-hpa@zytor.com> <8328.1328703626@redhat.com> <16325.1328736262@redhat.com> <4F32E98F.2090909@zytor.com> <30935.1329247114@redhat.com> <4F3AB99E.5040705@zytor.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: Received: from terminus.zytor.com ([198.137.202.10]:43806 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760635Ab2BNUOz (ORCPT ); Tue, 14 Feb 2012 15:14:55 -0500 In-Reply-To: <4F3AB99E.5040705@zytor.com> Sender: linux-arch-owner@vger.kernel.org List-ID: To: David Howells Cc: Tony Luck , linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, Linus Torvalds , Arnd Bergmann On 02/14/2012 11:44 AM, H. Peter Anvin wrote: > > We can do that, but we'd almost certainly have to #include > in . The following macros are defined in > and *exported to userspace*: > > #define NFDBITS __NFDBITS > > #define FD_SETSIZE __FD_SETSIZE > #define FD_SET(fd,fdsetp) __FD_SET(fd,fdsetp) > #define FD_CLR(fd,fdsetp) __FD_CLR(fd,fdsetp) > #define FD_ISSET(fd,fdsetp) __FD_ISSET(fd,fdsetp) > #define FD_ZERO(fdsetp) __FD_ZERO(fdsetp) > Note: yes, those macros are completely useless, obviously, since all they do is take what is already defined in userspace and reflect it back out. Still, removing them is a userspace-visible change and really should be its own change with nothing else. -hpa