From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH 1/3] Kbuild: centralize MKIMAGE and cmd_uimage definitions Date: Wed, 07 Mar 2012 10:41:52 -0700 Message-ID: <4F579DE0.3050400@wwwdotorg.org> References: <1331080238-1524-1-git-send-email-swarren@wwwdotorg.org> <201203062256.16105.vapier@gentoo.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <201203062256.16105.vapier@gentoo.org> Sender: linux-sh-owner@vger.kernel.org To: Mike Frysinger Cc: Michal Marek , Russell King , nico@fluxnic.net, Haavard Skinnemoen , Hans-Christian Egtvedt , Michal Simek , Paul Mundt , "David S. Miller" , Guan Xuetao , linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org, linux-arm-kernel@lists.infradead.org, uclinux-dist-devel@blackfin.uclinux.org, microblaze-uclinux@itee.uq.edu.au, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-arch@vger.kernel.org List-Id: linux-arch.vger.kernel.org On 03/06/2012 08:56 PM, Mike Frysinger wrote: > On Tuesday 06 March 2012 19:30:36 Stephen Warren wrote: >> --- a/arch/blackfin/boot/Makefile >> +++ b/arch/blackfin/boot/Makefile >> >> +ifeq ($(CONFIG_RAMKERNEL),y) >> +UIMAGE_LOADADDR = $(CONFIG_BOOT_LOAD) >> +else # CONFIG_ROMKERNEL must be set >> +UIMAGE_LOADADDR = $(CONFIG_BOOT_LOAD) >> +endif > > this part is wrong :). the else branch should be $(CONFIG_ROM_BASE). Thanks. I've fixed that locally. >> +UIMAGE_ENTRYADDR = $(shell $(NM) vmlinux | awk '$$NF == "__start" {print >> $$1}') > > i feel like if we tried harder, we could automate the -e arg for all arches. > i understand if you don't want to undertake that though. Yes, this might be possible. I'd guess the symbol name varies between archs, but that can probably be taken care of. This is probably best left as a follow-on patch though, since it's a behavioral change, whereas this patch is just consolidation. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from avon.wwwdotorg.org ([70.85.31.133]:47311 "EHLO avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932578Ab2CGRl5 (ORCPT ); Wed, 7 Mar 2012 12:41:57 -0500 Message-ID: <4F579DE0.3050400@wwwdotorg.org> Date: Wed, 07 Mar 2012 10:41:52 -0700 From: Stephen Warren MIME-Version: 1.0 Subject: Re: [PATCH 1/3] Kbuild: centralize MKIMAGE and cmd_uimage definitions References: <1331080238-1524-1-git-send-email-swarren@wwwdotorg.org> <201203062256.16105.vapier@gentoo.org> In-Reply-To: <201203062256.16105.vapier@gentoo.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: Mike Frysinger Cc: Michal Marek , Russell King , nico@fluxnic.net, Haavard Skinnemoen , Hans-Christian Egtvedt , Michal Simek , Paul Mundt , "David S. Miller" , Guan Xuetao , linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org, linux-arm-kernel@lists.infradead.org, uclinux-dist-devel@blackfin.uclinux.org, microblaze-uclinux@itee.uq.edu.au, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-arch@vger.kernel.org Message-ID: <20120307174152.fkSuP8B4rE88mLr9wHH2CXxRTUFI9eLbi1IVPBMZdn4@z> On 03/06/2012 08:56 PM, Mike Frysinger wrote: > On Tuesday 06 March 2012 19:30:36 Stephen Warren wrote: >> --- a/arch/blackfin/boot/Makefile >> +++ b/arch/blackfin/boot/Makefile >> >> +ifeq ($(CONFIG_RAMKERNEL),y) >> +UIMAGE_LOADADDR = $(CONFIG_BOOT_LOAD) >> +else # CONFIG_ROMKERNEL must be set >> +UIMAGE_LOADADDR = $(CONFIG_BOOT_LOAD) >> +endif > > this part is wrong :). the else branch should be $(CONFIG_ROM_BASE). Thanks. I've fixed that locally. >> +UIMAGE_ENTRYADDR = $(shell $(NM) vmlinux | awk '$$NF == "__start" {print >> $$1}') > > i feel like if we tried harder, we could automate the -e arg for all arches. > i understand if you don't want to undertake that though. Yes, this might be possible. I'd guess the symbol name varies between archs, but that can probably be taken care of. This is probably best left as a follow-on patch though, since it's a behavioral change, whereas this patch is just consolidation.