linux-arch.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@wwwdotorg.org>
To: gxt@mprc.pku.edu.cn
Cc: Michal Marek <mmarek@suse.cz>,
	Russell King <linux@arm.linux.org.uk>,
	nico@fluxnic.net, Haavard Skinnemoen <hskinnemoen@gmail.com>,
	Hans-Christian Egtvedt <egtvedt@samfundet.no>,
	Mike Frysinger <vapier@gentoo.org>,
	Michal Simek <monstr@monstr.eu>, Paul Mundt <lethal@linux-sh.org>,
	"David S. Miller" <davem@davemloft.net>,
	linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	uclinux-dist-devel@blackfin.uclinux.org,
	microblaze-uclinux@itee.uq.edu.au, linux-sh@vger.kernel.org,
	sparclinux@vger.kernel.org, linux-arch@vger.kernel.org
Subject: Re: [PATCH 2/3] Kbuild: Implement CONFIG_UIMAGE_KERNEL_NOLOAD
Date: Wed, 07 Mar 2012 11:10:19 -0700	[thread overview]
Message-ID: <4F57A48B.1060100@wwwdotorg.org> (raw)
In-Reply-To: <1331103163.2048.33.camel@epip-laptop>

On 03/06/2012 11:52 PM, Guan Xuetao wrote:
> On Tue, 2012-03-06 at 17:30 -0700, Stephen Warren wrote:
>> This allows the user to use U-Boot's mkimage's -T kernel_noload option
>> if their arch Kconfig allows it, and they desire.
...
> Hi, Stephen,
> It seems that UIMAGE_ARCH and UIMAGE_LOADADDR can't be modified from
> arch-Makefiles.

Oh dear, you're right. I suck at testing:-( I've fixed this locally.

For reference, Makefile.lib is included after the Makefile in the
relevant source directory, whereas my patch assumed the other way
around. So, rather than setting defaults in Makefile.lib and having
foo/Makefile override them, I should set the non-defaults in
foo/Makefile, and have Makefile.lib provide default values for variables
that aren't already set. Testing indicates this solves the problem!

  parent reply	other threads:[~2012-03-07 18:10 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-07  0:30 [PATCH 1/3] Kbuild: centralize MKIMAGE and cmd_uimage definitions Stephen Warren
2012-03-07  0:30 ` Stephen Warren
2012-03-07  0:30 ` [PATCH 2/3] Kbuild: Implement CONFIG_UIMAGE_KERNEL_NOLOAD Stephen Warren
2012-03-07  0:30   ` Stephen Warren
2012-03-07  0:52   ` Julian Calaby
2012-03-07  0:52     ` Julian Calaby
     [not found]   ` <1331080238-1524-2-git-send-email-swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-03-07  6:52     ` [microblaze-linux] " Guan Xuetao
2012-03-07  6:52       ` Guan Xuetao
2012-03-07 18:10       ` Stephen Warren [this message]
2012-03-07 18:08   ` Jean-Christophe PLAGNIOL-VILLARD
2012-03-07 18:08     ` Jean-Christophe PLAGNIOL-VILLARD
2012-03-07 18:40     ` Stephen Warren
2012-03-07 18:36       ` Jean-Christophe PLAGNIOL-VILLARD
2012-03-07 19:02         ` Nicolas Pitre
2012-03-07 20:27         ` Stephen Warren
2012-03-07 21:03           ` Nicolas Pitre
2012-03-07 21:03             ` Nicolas Pitre
2012-03-07 21:30             ` Russell King - ARM Linux
2012-03-07 22:43               ` Nicolas Pitre
2012-03-07 21:28           ` Russell King - ARM Linux
2012-03-07 18:40       ` Stephen Warren
2012-03-07 18:50     ` Nicolas Pitre
2012-03-07 19:08       ` Jean-Christophe PLAGNIOL-VILLARD
2012-03-07 19:08         ` Jean-Christophe PLAGNIOL-VILLARD
2012-03-07 19:31         ` Nicolas Pitre
2012-03-07 19:31           ` Nicolas Pitre
2012-03-07  0:30 ` [PATCH 3/3] ARM: Allow the user to enable UIMAGE_KERNEL_NOLOAD Stephen Warren
2012-03-07  0:30   ` Stephen Warren
2012-03-07  3:56 ` [PATCH 1/3] Kbuild: centralize MKIMAGE and cmd_uimage definitions Mike Frysinger
2012-03-07  3:56   ` Mike Frysinger
2012-03-07 17:41   ` Stephen Warren
2012-03-07 17:41     ` Stephen Warren
2012-03-07 18:25     ` Mike Frysinger
2012-03-07  9:00 ` Hans-Christian Egtvedt
2012-03-07  9:00   ` Hans-Christian Egtvedt
2012-03-07 14:15 ` Josh Boyer
2012-03-07 18:29   ` Stephen Warren
2012-03-07 18:29     ` Stephen Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F57A48B.1060100@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=davem@davemloft.net \
    --cc=egtvedt@samfundet.no \
    --cc=gxt@mprc.pku.edu.cn \
    --cc=hskinnemoen@gmail.com \
    --cc=lethal@linux-sh.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=microblaze-uclinux@itee.uq.edu.au \
    --cc=mmarek@suse.cz \
    --cc=monstr@monstr.eu \
    --cc=nico@fluxnic.net \
    --cc=sparclinux@vger.kernel.org \
    --cc=uclinux-dist-devel@blackfin.uclinux.org \
    --cc=vapier@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).