From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guan Xueao Subject: Re: [PATCH] Kbuild: centralize MKIMAGE and cmd_uimage definitions Date: Mon, 19 Mar 2012 17:05:35 +0800 Message-ID: <4F66F6DF.8010609@pku.edu.cn> References: <1331931835-12346-1-git-send-email-swarren@wwwdotorg.org> Reply-To: gxt@mprc.pku.edu.cn Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mx6.pku.edu.cn ([162.105.129.60]:43956 "EHLO mail.pku.edu.cn" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754326Ab2CSJEp (ORCPT ); Mon, 19 Mar 2012 05:04:45 -0400 In-Reply-To: <1331931835-12346-1-git-send-email-swarren@wwwdotorg.org> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Stephen Warren Cc: Michal Marek , Russell King , nico@fluxnic.net, Haavard Skinnemoen , Hans-Christian Egtvedt , Mike Frysinger , Michal Simek , Paul Mundt , "David S. Miller" , linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org, linux-arm-kernel@lists.infradead.org, uclinux-dist-devel@blackfin.uclinux.org, microblaze-uclinux@itee.uq.edu.au, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-arch@vger.kernel.org On 03/17/2012 05:03 AM, Stephen Warren wrote: > All ARCHs have the same definition of MKIMAGE. Move it to Makefile.lib > to avoid duplication. > > All ARCHs have similar definitions of cmd_uimage. Place a sufficiently > parameterized version in Makefile.lib to avoid duplication. > > Signed-off-by: Stephen Warren > --- > v2: > * Fix blackfin's UIMAGE_LOADADDR in the ROMKERNEL case. > * Fix missing ) on a variable reference in avr32 and sparc. > * Only set those UIMAGE_* variables that the arch-specific Makefile hasn't > already set. > * The patch series is now just this single patch which removes duplication; > I've dropped the Kconfig feature to allow use of -T kernel_noload for > now, since it looks like U-Boot is gaining direct zImage support. > > Tested on unicore32. Tested-by: Guan Xuetao