From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michal Marek Subject: Re: [PATCH] Kbuild: centralize MKIMAGE and cmd_uimage definitions Date: Mon, 26 Mar 2012 15:48:42 +0200 Message-ID: <4F7073BA.6040403@suse.cz> References: <1331931835-12346-1-git-send-email-swarren@wwwdotorg.org> <4F6B7226.8000102@wwwdotorg.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from cantor2.suse.de ([195.135.220.15]:41162 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757248Ab2CZNst (ORCPT ); Mon, 26 Mar 2012 09:48:49 -0400 In-Reply-To: <4F6B7226.8000102@wwwdotorg.org> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Stephen Warren Cc: Russell King , nico@fluxnic.net, Haavard Skinnemoen , Hans-Christian Egtvedt , Mike Frysinger , Michal Simek , Paul Mundt , "David S. Miller" , Guan Xuetao , linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org, linux-arm-kernel@lists.infradead.org, uclinux-dist-devel@blackfin.uclinux.org, microblaze-uclinux@itee.uq.edu.au, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-arch@vger.kernel.org On 22.3.2012 19:40, Stephen Warren wrote: > On 03/16/2012 03:03 PM, Stephen Warren wrote: >> All ARCHs have the same definition of MKIMAGE. Move it to Makefile.lib >> to avoid duplication. >> >> All ARCHs have similar definitions of cmd_uimage. Place a sufficiently >> parameterized version in Makefile.lib to avoid duplication. > > Michal, > > Does this change look reasonable? Absolutely. > It has acks from people working on 4 > of the 7 affected architectures; would you prefer acks from all? I will apply it now. Michal