From mboxrd@z Thu Jan 1 00:00:00 1970 From: "H. Peter Anvin" Subject: Re: [PATCH v17 08/15] seccomp: add system call filtering using BPF Date: Fri, 06 Apr 2012 14:06:01 -0700 Message-ID: <4F7F5AB9.5040309@zytor.com> References: <1333051320-30872-1-git-send-email-wad@chromium.org> <1333051320-30872-9-git-send-email-wad@chromium.org> <20120406132330.457a05cf.akpm@linux-foundation.org> <20120406140503.10b75c5b.akpm@linux-foundation.org> Reply-To: kernel-hardening@lists.openwall.com Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: List-Post: List-Help: List-Unsubscribe: List-Subscribe: In-Reply-To: <20120406140503.10b75c5b.akpm@linux-foundation.org> To: Andrew Morton Cc: Kees Cook , Will Drewry , linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, linux-arch@vger.kernel.org, linux-doc@vger.kernel.org, kernel-hardening@lists.openwall.com, netdev@vger.kernel.org, x86@kernel.org, arnd@arndb.de, davem@davemloft.net, mingo@redhat.com, oleg@redhat.com, peterz@infradead.org, rdunlap@xenotime.net, mcgrathr@chromium.org, tglx@linutronix.de, luto@mit.edu, eparis@redhat.com, serge.hallyn@canonical.com, djm@mindrot.org, scarybeasts@gmail.com, indan@nul.nu, pmoore@redhat.com, corbet@lwn.net, eric.dumazet@gmail.com, markus@chromium.org, coreyb@linux.vnet.ibm.com, jmorris@namei.org List-Id: linux-arch.vger.kernel.org On 04/06/2012 02:05 PM, Andrew Morton wrote: >>> >>> hm, I'm surprised that we don't have a zero-returning implementation of >>> is_compat_task() when CONFIG_COMPAT=n. Seems silly. Blames Arnd. >> >> There is > > I can't find it. The definition in include/linux/compat.h is inside > #ifdef CONFIG_COMPAT. > I thought Linus globalized it very recently... -hpa From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from terminus.zytor.com ([198.137.202.10]:46359 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758140Ab2DFVHT (ORCPT ); Fri, 6 Apr 2012 17:07:19 -0400 Message-ID: <4F7F5AB9.5040309@zytor.com> Date: Fri, 06 Apr 2012 14:06:01 -0700 From: "H. Peter Anvin" MIME-Version: 1.0 Subject: Re: [PATCH v17 08/15] seccomp: add system call filtering using BPF References: <1333051320-30872-1-git-send-email-wad@chromium.org> <1333051320-30872-9-git-send-email-wad@chromium.org> <20120406132330.457a05cf.akpm@linux-foundation.org> <20120406140503.10b75c5b.akpm@linux-foundation.org> In-Reply-To: <20120406140503.10b75c5b.akpm@linux-foundation.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: Andrew Morton Cc: Kees Cook , Will Drewry , linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, linux-arch@vger.kernel.org, linux-doc@vger.kernel.org, kernel-hardening@lists.openwall.com, netdev@vger.kernel.org, x86@kernel.org, arnd@arndb.de, davem@davemloft.net, mingo@redhat.com, oleg@redhat.com, peterz@infradead.org, rdunlap@xenotime.net, mcgrathr@chromium.org, tglx@linutronix.de, luto@mit.edu, eparis@redhat.com, serge.hallyn@canonical.com, djm@mindrot.org, scarybeasts@gmail.com, indan@nul.nu, pmoore@redhat.com, corbet@lwn.net, eric.dumazet@gmail.com, markus@chromium.org, coreyb@linux.vnet.ibm.com, jmorris@namei.org Message-ID: <20120406210601.UXhuBFc8znzV8BrGTNND-dORUGsZEOFW8TAhFA3X9NE@z> On 04/06/2012 02:05 PM, Andrew Morton wrote: >>> >>> hm, I'm surprised that we don't have a zero-returning implementation of >>> is_compat_task() when CONFIG_COMPAT=n. Seems silly. Blames Arnd. >> >> There is > > I can't find it. The definition in include/linux/compat.h is inside > #ifdef CONFIG_COMPAT. > I thought Linus globalized it very recently... -hpa