From mboxrd@z Thu Jan 1 00:00:00 1970 From: "H. Peter Anvin" Subject: Re: [RFC][PATCH 3/3] math128, x86_64: Implement {mult,add}_u128 in 64bit asm Date: Tue, 24 Apr 2012 15:03:13 -0700 Message-ID: <4F972321.4010009@zytor.com> References: <20120424161039.293018424@chello.nl> <20120424162224.588822231@chello.nl> <4F96D604.5050709@zytor.com> <1335285395.28150.204.camel@twins> <4F96E01E.6040109@zytor.com> <1335287973.28150.213.camel@twins> <4F96E0EB.7030904@zytor.com> <1335304843.28150.246.camel@twins> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from terminus.zytor.com ([198.137.202.10]:38026 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757015Ab2DXWDb (ORCPT ); Tue, 24 Apr 2012 18:03:31 -0400 In-Reply-To: <1335304843.28150.246.camel@twins> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Peter Zijlstra Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, Linus Torvalds , Andrew Morton , Juri Lelli , Ingo Molnar , Thomas Gleixner On 04/24/2012 03:00 PM, Peter Zijlstra wrote: > > I haven't been able to make add_u128 generate sane code using __int128, > the conversion between my struct and the __int128 layout makes a horrid > mess. > Use a union, or define your type simply as __int128 if you're on a suitable platform? -hpa